Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 1/1] avcodec/aac_ac3_parser: fix the warning caused by bit_rate not being initialized.
@ 2025-09-04 11:16 岑湛权 via ffmpeg-devel
  0 siblings, 0 replies; only message in thread
From: 岑湛权 via ffmpeg-devel @ 2025-09-04 11:16 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: zhanquan cen

From: zhanquan cen <cenzhanquan2@gmail.com>

CC:  ffmpeg/libavcodec/alac_data.c ffmpeg/libavcodec/aac_ac3_parser.c:97:13: warning: variable 'bit_rate' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
        if (avctx->codec_id != AV_CODEC_ID_AAC) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ffmpeg/libavcodec/aac_ac3_parser.c:160:18: note: uninitialized use occurs here
                (bit_rate - avctx->bit_rate) / s->frame_number;
                 ^~~~~~~~
ffmpeg/libavcodec/aac_ac3_parser.c:97:9: note: remove the 'if' if its condition is always false
        if (avctx->codec_id != AV_CODEC_ID_AAC) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ffmpeg/libavcodec/aac_ac3_parser.c:90:21: note: initialize the variable 'bit_rate' to silence this warning
        int bit_rate;
                    ^
                     = 0

Signed-off-by: zhanquan cen <cenzhanquan2@gmail.com>
---
 libavcodec/aac_ac3_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/aac_ac3_parser.c b/libavcodec/aac_ac3_parser.c
index 51c801214c..5b015f2843 100644
--- a/libavcodec/aac_ac3_parser.c
+++ b/libavcodec/aac_ac3_parser.c
@@ -89,7 +89,7 @@ get_next:
     *poutbuf_size = buf_size;
 
     if (got_frame) {
-        int bit_rate;
+        int bit_rate = 0;
 
         /* Due to backwards compatible HE-AAC the sample rate, channel count,
            and total number of samples found in an AAC ADTS header are not
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-09-04 11:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-04 11:16 [FFmpeg-devel] [PATCH 1/1] avcodec/aac_ac3_parser: fix the warning caused by bit_rate not being initialized 岑湛权 via ffmpeg-devel

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git