[FFmpeg-devel] Re: [PATCH v3 2/2] avcodec/libaom: Add test for HDR10+ metadata support

[Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1.1: Type: text/plain, Size: 5470 bytes --]

On Tue, Sep 02, 2025 at 10:39:12AM -0300, James Almer via ffmpeg-devel wrote:
> On 9/2/2025 10:30 AM, Michael Niedermayer via ffmpeg-devel wrote:
> > On Wed, Aug 27, 2025 at 01:06:42PM +0200, Maryla Ustarroz via ffmpeg-devel wrote:
> > > On Mon, Aug 11, 2025 at 2:01 PM Maryla Ustarroz <maryla@google.com> wrote:
> > > > 
> > > > On Mon, Aug 11, 2025 at 1:57 PM Maryla Ustarroz-Calonge
> > > > <maryla@google.com> wrote:
> > > > > 
> > > > > Signed-off-by: Maryla Ustarroz-Calonge <maryla@google.com>
> > > > > ---
> > > > >   tests/Makefile                   |  1 +
> > > > >   tests/fate/av1.mak               |  7 +++++
> > > > >   tests/ref/fate/libaom-hdr10-plus | 44 ++++++++++++++++++++++++++++++++
> > > > >   3 files changed, 52 insertions(+)
> > > > >   create mode 100644 tests/fate/av1.mak
> > > > >   create mode 100644 tests/ref/fate/libaom-hdr10-plus
> > > > > 
> > > > > diff --git a/tests/Makefile b/tests/Makefile
> > > > > index 3f4dbaabfd..3eef290e41 100644
> > > > > --- a/tests/Makefile
> > > > > +++ b/tests/Makefile
> > > > > @@ -162,6 +162,7 @@ include $(SRC_PATH)/tests/fate/apng.mak
> > > > >   include $(SRC_PATH)/tests/fate/apv.mak
> > > > >   include $(SRC_PATH)/tests/fate/atrac.mak
> > > > >   include $(SRC_PATH)/tests/fate/audio.mak
> > > > > +include $(SRC_PATH)/tests/fate/av1.mak
> > > > >   include $(SRC_PATH)/tests/fate/bmp.mak
> > > > >   include $(SRC_PATH)/tests/fate/build.mak
> > > > >   include $(SRC_PATH)/tests/fate/caf.mak
> > > > > diff --git a/tests/fate/av1.mak b/tests/fate/av1.mak
> > > > > new file mode 100644
> > > > > index 0000000000..81072be5b8
> > > > > --- /dev/null
> > > > > +++ b/tests/fate/av1.mak
> > > > > @@ -0,0 +1,7 @@
> > > > > +# Tests that reading and writing with codec libaom-av1 preserves HDR10+ metadata.
> > > > > +FATE_AV1_FFMPEG_FFPROBE-$(call ENCDEC, LIBAOM_AV1 VP9, IVF MATROSKA) += fate-libaom-hdr10-plus
> > > > > +fate-libaom-hdr10-plus: CMD = enc_external $(TARGET_SAMPLES)/mkv/hdr10_plus_vp9_sample.webm ivf "-map 0 -c:v libaom-av1 -cpu-used 8" "-show_frames -show_entries frame=side_data_list -codec:v libaom-av1"
> > > > > +
> > > > > +FATE_SAMPLES_FFMPEG_FFPROBE += $(FATE_AV1_FFMPEG_FFPROBE-yes)
> > > > > +
> > > > > +fate-av1: $(FATE_AV1_FFMPEG_FFPROBE-yes)
> > > > > diff --git a/tests/ref/fate/libaom-hdr10-plus b/tests/ref/fate/libaom-hdr10-plus
> > > > > new file mode 100644
> > > > > index 0000000000..c03dda7e7f
> > > > > --- /dev/null
> > > > > +++ b/tests/ref/fate/libaom-hdr10-plus
> > > > > @@ -0,0 +1,44 @@
> > > > > +[FRAME]
> > > > > +[SIDE_DATA]
> > > > > +side_data_type=HDR Dynamic Metadata SMPTE2094-40 (HDR10+)
> > > > > +application version=1
> > > > > +num_windows=1
> > > > > +targeted_system_display_maximum_luminance=400/1
> > > > > +maxscl=3340/100000
> > > > > +maxscl=2870/100000
> > > > > +maxscl=2720/100000
> > > > > +average_maxrgb=510/100000
> > > > > +num_distribution_maxrgb_percentiles=9
> > > > > +distribution_maxrgb_percentage=1
> > > > > +distribution_maxrgb_percentile=30/100000
> > > > > +distribution_maxrgb_percentage=5
> > > > > +distribution_maxrgb_percentile=2940/100000
> > > > > +distribution_maxrgb_percentage=10
> > > > > +distribution_maxrgb_percentile=255/100000
> > > > > +distribution_maxrgb_percentage=25
> > > > > +distribution_maxrgb_percentile=70/100000
> > > > > +distribution_maxrgb_percentage=50
> > > > > +distribution_maxrgb_percentile=1340/100000
> > > > > +distribution_maxrgb_percentage=75
> > > > > +distribution_maxrgb_percentile=1600/100000
> > > > > +distribution_maxrgb_percentage=90
> > > > > +distribution_maxrgb_percentile=1850/100000
> > > > > +distribution_maxrgb_percentage=95
> > > > > +distribution_maxrgb_percentile=1950/100000
> > > > > +distribution_maxrgb_percentage=99
> > > > > +distribution_maxrgb_percentile=2940/100000
> > > > > +fraction_bright_pixels=1/1000
> > > > > +knee_point_x=0/4095
> > > > > +knee_point_y=0/4095
> > > > > +num_bezier_curve_anchors=9
> > > > > +bezier_curve_anchors=102/1023
> > > > > +bezier_curve_anchors=205/1023
> > > > > +bezier_curve_anchors=307/1023
> > > > > +bezier_curve_anchors=410/1023
> > > > > +bezier_curve_anchors=512/1023
> > > > > +bezier_curve_anchors=614/1023
> > > > > +bezier_curve_anchors=717/1023
> > > > > +bezier_curve_anchors=819/1023
> > > > > +bezier_curve_anchors=922/1023
> > > > > +[/SIDE_DATA]
> > > > > +[/FRAME]
> > > > > \ No newline at end of file
> > > > > --
> > > > > 2.50.1.703.g449372360f-goog
> > > > 
> > > > Note that this is a simplified version of v2 now that ffprobe supports
> > > > the -codec:v flag.
> > > > This allows testing reading and writing of HDR10+ metadata in a single test, and
> > > > removes the need for a new test file.
> > > 
> > > Friendly ping.
> > 
> > will apply patchset
> 
> Fix the no newline at end of file part before pushing, please.

will do

thx for noticing

iam also fixing all the "via ffmpeg-devel" Authors

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org