From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 94C8D46CED for ; Thu, 14 Aug 2025 14:06:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1495A68D24A; Thu, 14 Aug 2025 17:06:51 +0300 (EEST) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 122CA687A93 for ; Thu, 14 Aug 2025 17:06:44 +0300 (EEST) Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3e575ff1b80so2681265ab.3 for ; Thu, 14 Aug 2025 07:06:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755180402; x=1755785202; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PR7Buvh1vPDsUJa53mM3yDax+UudjpLgOURn2gPDbVo=; b=MMm4OKVNCHkgClmjs90///HTPGKeRKsshaU5g6mPLsv6mdWRfnjf0rwNU8JnyYSqLh YWvaYDBX66ZdiU8mp2gGNbhMMUI1E/Yp0NrbN2TGMAZqNsyjzlRgpD8OMlF0edgrnWlE WucqO8N929wdzuTgW/hbWqG+P460SC6LY421MCghcRnr14VadpRY2lAA9qj2gHe7IXIK kwE1mb4lf0JkFKk/l6NSqk+/y8U8+KBf8qiBn0NesOOn4V02s/suZgAdsalKH2jxvykk P+5iPFdlypi3IR+1KIINM6oMJRE3P6TLyw58xwoDpQ3IfuwxLCyCDvPA526hpRo3+/vq LOIQ== X-Gm-Message-State: AOJu0YxAdUL73EXzTZ4Fm3jm6mpor1g8lOqfrfEdDRABfGhEFSFHpqLs h5+izrzwXwBLzrUreZFlsgKJwQeLu6IJnDTheeSS8kzvGUIcn/4JlHepGpFpHA== X-Gm-Gg: ASbGncvoOpb4KdmIC4BMt9xMO0aGRnB7MOAvsGQzVdvmdMt14AJRGNrRatJMa9cbXgH MS+J2WQAXJlCfd54SomcQYpGyZsn/fdFvIaYtgtBXzE44JVTELxOiX1aa4uy1do1VkTUIhAOAE/ tQzJu4qbjlaizuPdT3HELQG4Rl+ytAfFGls+Yf5IH+jTE9MW46mg8ayWZDAbS5bAZvg4SS+iT05 xfD2GYUeoxOzX71ziPg+fME6s7omtdfFRV1OJas4V10Fh2T46mW+RwnNdJPu9HsaPL2yh9tY9Kb c3W6mkl/1q5lLe1HP/ZMgJ7gD9KPxJntLJO/SDJaqv8lrJDGIZ3DZx/1NqdsBL2k6mz7X0KmNsh Wi98XXEdd1OkDSXXaWGjj7FRsj0ng4JhVWWswfGctjIBb X-Google-Smtp-Source: AGHT+IGxDwdapqQJ6nVyzGf5XWbdenrKFyaRhm1ERZLMr25iehKSfPmEJ9ljxLzZ2Fwgy/nD/WO2mA== X-Received: by 2002:a05:6e02:17c9:b0:3e5:2df0:4b7e with SMTP id e9e14a558f8ab-3e57078be46mr62635415ab.7.1755180395468; Thu, 14 Aug 2025 07:06:35 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e54270f79fsm52146465ab.7.2025.08.14.07.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 07:06:34 -0700 (PDT) To: ffmpeg-devel@ffmpeg.org Date: Thu, 14 Aug 2025 14:06:32 +0000 Message-Id: <20250814140632.2040-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] libavutil/tests/lzo: Add check to avoid potential NULL pointer dereference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jiasheng Jiang via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add av_free() if qf_vid is NULL to avoid potential memory leak. Fixes: 5d48e4eafa ("Merge commit 'a6a750c7ef240b72ce01e9653343a0ddf247d196'") Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. Add check for in to avoid calling flcose(NULL). --- libavutil/tests/lzo.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavutil/tests/lzo.c b/libavutil/tests/lzo.c index d7a78a1696..312e70e8ef 100644 --- a/libavutil/tests/lzo.c +++ b/libavutil/tests/lzo.c @@ -45,6 +45,10 @@ int main(int argc, char *argv[]) { long tmp[LZO1X_MEM_COMPRESS]; int inlen, outlen; int i; + + if (!in || !orig || !comp || !decomp) + goto end; + av_log_set_level(AV_LOG_DEBUG); if (comp_level == 0) { lzo1x_1_compress(orig, s, comp, &clen, tmp); @@ -71,7 +75,10 @@ int main(int argc, char *argv[]) { av_log(NULL, AV_LOG_ERROR, "decompression incorrect\n"); else av_log(NULL, AV_LOG_ERROR, "decompression OK\n"); - fclose(in); + +end: + if (in) + fclose(in); av_free(orig); av_free(comp); av_free(decomp); -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".