[FFmpeg-devel] [PATCH v2] libavutil/tests/lzo: Add check to avoid potential NULL pointer dereference

[FFmpeg-devel] [PATCH v2] libavutil/tests/lzo: Add check to avoid potential NULL pointer dereference

[Jiasheng Jiang via ffmpeg-devel]

Add av_free() if qf_vid is NULL to avoid potential memory leak.

Fixes: 5d48e4eafa ("Merge commit 'a6a750c7ef240b72ce01e9653343a0ddf247d196'")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
Changelog:

v1 -> v2:

1. Add check for in to avoid calling flcose(NULL).
---
 libavutil/tests/lzo.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/libavutil/tests/lzo.c b/libavutil/tests/lzo.c
index d7a78a1696..312e70e8ef 100644
--- a/libavutil/tests/lzo.c
+++ b/libavutil/tests/lzo.c
@@ -45,6 +45,10 @@ int main(int argc, char *argv[]) {
     long tmp[LZO1X_MEM_COMPRESS];
     int inlen, outlen;
     int i;
+
+    if (!in || !orig || !comp || !decomp)
+        goto end;
+
     av_log_set_level(AV_LOG_DEBUG);
     if (comp_level == 0) {
         lzo1x_1_compress(orig, s, comp, &clen, tmp);
@@ -71,7 +75,10 @@ int main(int argc, char *argv[]) {
         av_log(NULL, AV_LOG_ERROR, "decompression incorrect\n");
     else
         av_log(NULL, AV_LOG_ERROR, "decompression OK\n");
-    fclose(in);
+
+end:
+    if (in)
+        fclose(in);
     av_free(orig);
     av_free(comp);
     av_free(decomp);
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".