From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7E538410B1 for ; Tue, 12 Aug 2025 23:09:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id CEA1F68B760; Wed, 13 Aug 2025 02:09:14 +0300 (EEST) Received: from 4cfb3de38520 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id AB09C68CBF0 for ; Wed, 13 Aug 2025 02:09:12 +0300 (EEST) MIME-Version: 1.0 From: michaelni To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] =?utf-8?q?=5BPATCH=5D_fftools/ffmpeg=5Fmux=5Finit?= =?utf-8?q?=3A_Use_64bit_for_score_computation_in_map=5Fauto=5Fvideo=28=29?= =?utf-8?b?IChQUiAjMjAyMjkp?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-Id: <20250812230914.CEA1F68B760@ffbox0-bg.ffmpeg.org> Date: Wed, 13 Aug 2025 02:09:14 +0300 (EEST) Archived-At: List-Archive: List-Post: PR #20229 opened by michaelni URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20229 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20229.patch Fixes: signed integer overflow: 10 * 1952737655 cannot be represented in type 'int' Fixes: PoC_avi_demux Found-by: 2ourc3 (Salim LARGO) Signed-off-by: Michael Niedermayer >From a3accb09575ba6ad7a9925d0c18e2ad79da6ca7d Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Wed, 13 Aug 2025 00:59:20 +0200 Subject: [PATCH] fftools/ffmpeg_mux_init: Use 64bit for score computation in map_auto_video() Fixes: signed integer overflow: 10 * 1952737655 cannot be represented in type 'int' Fixes: PoC_avi_demux Found-by: 2ourc3 (Salim LARGO) Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_mux_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 4a973e5286..48b2220bfa 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1613,7 +1613,7 @@ static int map_auto_video(Muxer *mux, const OptionsContext *o) ist->st->codecpar->codec_type != AVMEDIA_TYPE_VIDEO) continue; - score = ist->st->codecpar->width * ist->st->codecpar->height + score = ist->st->codecpar->width * (int64_t)ist->st->codecpar->height + 100000000 * !!(ist->st->event_flags & AVSTREAM_EVENT_FLAG_NEW_PACKETS) + 5000000*!!(ist->st->disposition & AV_DISPOSITION_DEFAULT); if((qcr!=MKTAG('A', 'P', 'I', 'C')) && (ist->st->disposition & AV_DISPOSITION_ATTACHED_PIC)) -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".