From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] testa/fate/cbs: move redundant_pps tests to the proper location
Date: Tue, 12 Aug 2025 12:32:17 -0300
Message-ID: <20250812153217.9438-1-jamrial@gmail.com> (raw)
cbs.mak is meant to contain tests strictly for the CBS framework, not for any
bsf that happens to use it under the hood.
Signed-off-by: James Almer <jamrial@gmail.com>
---
tests/fate/cbs.mak | 40 +------------------
tests/fate/h264.mak | 17 ++++++++
...s-annexb => h264-bsf-redundant-pps-annexb} | 4 +-
...ant_pps-mov => h264-bsf-redundant-pps-mov} | 4 +-
..._data => h264-bsf-redundant-pps-side-data} | 4 +-
...ata2 => h264-bsf-redundant-pps-side-data2} | 4 +-
6 files changed, 27 insertions(+), 46 deletions(-)
rename tests/ref/fate/{h264_redundant_pps-annexb => h264-bsf-redundant-pps-annexb} (99%)
rename tests/ref/fate/{h264_redundant_pps-mov => h264-bsf-redundant-pps-mov} (97%)
rename tests/ref/fate/{h264_redundant_pps-side_data => h264-bsf-redundant-pps-side-data} (86%)
rename tests/ref/fate/{h264_redundant_pps-side_data2 => h264-bsf-redundant-pps-side-data2} (68%)
diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak
index a4512355bf..d6a576b322 100644
--- a/tests/fate/cbs.mak
+++ b/tests/fate/cbs.mak
@@ -101,44 +101,8 @@ $(foreach N,$(FATE_CBS_DISCARD_TYPES),$(eval $(call FATE_CBS_DISCARD_TEST,h264,$
FATE_CBS_H264-$(call ALLYES, MOV_DEMUXER H264_MUXER H264_PARSER FILTER_UNITS_BSF H264_METADATA_BSF) += $(FATE_CBS_h264_DISCARD)
-
-FATE_H264_REDUNDANT_PPS-$(call REMUX, H264, MOV_DEMUXER H264_REDUNDANT_PPS_BSF \
- H264_DECODER H264_PARSER RAWVIDEO_ENCODER) \
- += fate-h264_redundant_pps-mov
-fate-h264_redundant_pps-mov: CMD = transcode \
- mov $(TARGET_SAMPLES)/mov/frag_overlap.mp4 h264 \
- "-map 0:v -c copy -bsf h264_redundant_pps"
-
-# This file has changing pic_init_qp_minus26.
-FATE_H264_REDUNDANT_PPS-$(call REMUX, H264, H264_PARSER H264_REDUNDANT_PPS_BSF \
- H264_DECODER RAWVIDEO_ENCODER) \
- += fate-h264_redundant_pps-annexb
-fate-h264_redundant_pps-annexb: CMD = transcode \
- h264 $(TARGET_SAMPLES)/h264-conformance/CABA3_TOSHIBA_E.264 \
- h264 "-map 0:v -c copy -bsf h264_redundant_pps"
-
-# These two tests test that new extradata in packet side data is properly
-# modified by h264_redundant_pps. nut is used as destination container
-# because it can store extradata updates (in its experimental mode);
-# setting -syncpoints none is a hack to use nut version 4.
-FATE_H264_REDUNDANT_PPS-$(call REMUX, NUT, MOV_DEMUXER H264_REDUNDANT_PPS_BSF H264_DECODER) \
- += fate-h264_redundant_pps-side_data
-fate-h264_redundant_pps-side_data: CMD = transcode \
- mov $(TARGET_SAMPLES)/h264/thezerotheorem-cut.mp4 nut \
- "-map 0:v -c copy -bsf h264_redundant_pps -syncpoints none -strict experimental" "-c copy"
-
-FATE_H264_REDUNDANT_PPS-$(call REMUX, NUT, MOV_DEMUXER H264_REDUNDANT_PPS_BSF \
- H264_DECODER SCALE_FILTER RAWVIDEO_ENCODER) \
- += fate-h264_redundant_pps-side_data2
-fate-h264_redundant_pps-side_data2: CMD = transcode \
- mov $(TARGET_SAMPLES)/h264/extradata-reload-multi-stsd.mov nut \
- "-map 0:v -c copy -bsf h264_redundant_pps -syncpoints none -strict experimental"
-
-fate-h264_redundant_pps: $(FATE_H264_REDUNDANT_PPS-yes)
-
-
-FATE_SAMPLES_FFMPEG += $(FATE_CBS_H264-yes) $(FATE_H264_REDUNDANT_PPS-yes)
-fate-cbs-h264: $(FATE_CBS_H264-yes) $(FATE_H264_REDUNDANT_PPS-yes)
+FATE_SAMPLES_FFMPEG += $(FATE_CBS_H264-yes)
+fate-cbs-h264: $(FATE_CBS_H264-yes)
# H.265 read/write
diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak
index 3a0bd22a27..dacaaab274 100644
--- a/tests/fate/h264.mak
+++ b/tests/fate/h264.mak
@@ -235,6 +235,11 @@ FATE_H264-$(call FRAMECRC, MOV H264, H264, H264_PARSER H264_MUXER H264_MP4TOANNE
FATE_H264-$(call FRAMECRC, MOV H264,, H264_PARSER MOV_MUXER DTS2PTS_BSF) += fate-h264-bsf-dts2pts
+FATE_H264-$(call REMUX, H264, MOV_DEMUXER H264_REDUNDANT_PPS_BSF H264_DECODER H264_PARSER RAWVIDEO_ENCODER) += fate-h264-bsf-redundant-pps-mov
+FATE_H264-$(call REMUX, H264, H264_PARSER H264_REDUNDANT_PPS_BSF H264_DECODER RAWVIDEO_ENCODER) += fate-h264-bsf-redundant-pps-annexb
+FATE_H264-$(call REMUX, NUT, MOV_DEMUXER H264_REDUNDANT_PPS_BSF H264_DECODER) += fate-h264-bsf-redundant-pps-side-data
+FATE_H264-$(call REMUX, NUT, MOV_DEMUXER H264_REDUNDANT_PPS_BSF H264_DECODER SCALE_FILTER RAWVIDEO_ENCODER) += fate-h264-bsf-redundant-pps-side-data2
+
FATE_H264-$(call FRAMECRC, MATROSKA, H264) += fate-h264-direct-bff
FATE_H264-$(call FRAMECRC, FLV, H264, SCALE_FILTER) += fate-h264-brokensps-2580
FATE_H264-$(call FRAMECRC, MXF, H264, PCM_S24LE_DECODER SCALE_FILTER ARESAMPLE_FILTER) += fate-h264-xavc-4389
@@ -478,5 +483,17 @@ fate-h264-afd: CMD = run ffprobe$(PROGSSUF)$(
-show_entries frame=width,height,crop_top,crop_bottom,crop_left,crop_right:frame_side_data_list:stream=width,height,coded_width,coded_height \
$(TARGET_SAMPLES)/h264/bbc2.sample.h264
+fate-h264-bsf-redundant-pps-mov: CMD = transcode mov $(TARGET_SAMPLES)/mov/frag_overlap.mp4 h264 "-map 0:v -c copy -bsf h264_redundant_pps"
+
+# This file has changing pic_init_qp_minus26.
+fate-h264-bsf-redundant-pps-annexb: CMD = transcode h264 $(TARGET_SAMPLES)/h264-conformance/CABA3_TOSHIBA_E.264 h264 "-map 0:v -c copy -bsf h264_redundant_pps"
+
+# These two tests test that new extradata in packet side data is properly
+# modified by h264_redundant_pps. nut is used as destination container
+# because it can store extradata updates (in its experimental mode);
+# setting -syncpoints none is a hack to use nut version 4.
+fate-h264-bsf-redundant-pps-side-data: CMD = transcode mov $(TARGET_SAMPLES)/h264/thezerotheorem-cut.mp4 nut "-map 0:v -c copy -bsf h264_redundant_pps -syncpoints none -strict experimental" "-c copy"
+fate-h264-bsf-redundant-pps-side-data2: CMD = transcode mov $(TARGET_SAMPLES)/h264/extradata-reload-multi-stsd.mov nut "-map 0:v -c copy -bsf h264_redundant_pps -syncpoints none -strict experimental"
+
fate-h264-encparams: CMD = venc_data $(TARGET_SAMPLES)/h264-conformance/FRext/FRExt_MMCO4_Sony_B.264 0 1
FATE_SAMPLES_DUMP_DATA += fate-h264-encparams
diff --git a/tests/ref/fate/h264_redundant_pps-annexb b/tests/ref/fate/h264-bsf-redundant-pps-annexb
similarity index 99%
rename from tests/ref/fate/h264_redundant_pps-annexb
rename to tests/ref/fate/h264-bsf-redundant-pps-annexb
index 11d79f8b1f..a525c7bd59 100644
--- a/tests/ref/fate/h264_redundant_pps-annexb
+++ b/tests/ref/fate/h264-bsf-redundant-pps-annexb
@@ -1,5 +1,5 @@
-ce0890bd80342f8a3f6703f83b1c4959 *tests/data/fate/h264_redundant_pps-annexb.h264
-163967 tests/data/fate/h264_redundant_pps-annexb.h264
+ce0890bd80342f8a3f6703f83b1c4959 *tests/data/fate/h264-bsf-redundant-pps-annexb.h264
+163967 tests/data/fate/h264-bsf-redundant-pps-annexb.h264
#tb 0: 1/25
#media_type 0: video
#codec_id 0: rawvideo
diff --git a/tests/ref/fate/h264_redundant_pps-mov b/tests/ref/fate/h264-bsf-redundant-pps-mov
similarity index 97%
rename from tests/ref/fate/h264_redundant_pps-mov
rename to tests/ref/fate/h264-bsf-redundant-pps-mov
index a8a1fae933..453cd47783 100644
--- a/tests/ref/fate/h264_redundant_pps-mov
+++ b/tests/ref/fate/h264-bsf-redundant-pps-mov
@@ -1,5 +1,5 @@
-ac2e8f528dae4e4d610fa3517d2c94fb *tests/data/fate/h264_redundant_pps-mov.h264
-187284 tests/data/fate/h264_redundant_pps-mov.h264
+ac2e8f528dae4e4d610fa3517d2c94fb *tests/data/fate/h264-bsf-redundant-pps-mov.h264
+187284 tests/data/fate/h264-bsf-redundant-pps-mov.h264
#tb 0: 1001/24000
#media_type 0: video
#codec_id 0: rawvideo
diff --git a/tests/ref/fate/h264_redundant_pps-side_data b/tests/ref/fate/h264-bsf-redundant-pps-side-data
similarity index 86%
rename from tests/ref/fate/h264_redundant_pps-side_data
rename to tests/ref/fate/h264-bsf-redundant-pps-side-data
index 1f4684bf5b..cecbe1acf9 100644
--- a/tests/ref/fate/h264_redundant_pps-side_data
+++ b/tests/ref/fate/h264-bsf-redundant-pps-side-data
@@ -1,5 +1,5 @@
-92fe70291f72acf94ba56b426bbaccb0 *tests/data/fate/h264_redundant_pps-side_data.nut
-596100 tests/data/fate/h264_redundant_pps-side_data.nut
+92fe70291f72acf94ba56b426bbaccb0 *tests/data/fate/h264-bsf-redundant-pps-side-data.nut
+596100 tests/data/fate/h264-bsf-redundant-pps-side-data.nut
#extradata 0: 34, 0x850408e3
#tb 0: 1/48000
#media_type 0: video
diff --git a/tests/ref/fate/h264_redundant_pps-side_data2 b/tests/ref/fate/h264-bsf-redundant-pps-side-data2
similarity index 68%
rename from tests/ref/fate/h264_redundant_pps-side_data2
rename to tests/ref/fate/h264-bsf-redundant-pps-side-data2
index 7484fbeb07..2a483144e7 100644
--- a/tests/ref/fate/h264_redundant_pps-side_data2
+++ b/tests/ref/fate/h264-bsf-redundant-pps-side-data2
@@ -1,5 +1,5 @@
-dd953f8d95d2927703ce9593a07fe2e7 *tests/data/fate/h264_redundant_pps-side_data2.nut
-5162 tests/data/fate/h264_redundant_pps-side_data2.nut
+dd953f8d95d2927703ce9593a07fe2e7 *tests/data/fate/h264-bsf-redundant-pps-side-data2.nut
+5162 tests/data/fate/h264-bsf-redundant-pps-side-data2.nut
#tb 0: 1/25
#media_type 0: video
#codec_id 0: rawvideo
--
2.50.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-08-12 15:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812153217.9438-1-jamrial@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git