From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5AB284CF41 for ; Tue, 12 Aug 2025 10:04:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2C11F688FD9; Tue, 12 Aug 2025 13:04:53 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 97F7F68AFBE for ; Tue, 12 Aug 2025 13:04:46 +0300 (EEST) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with UTF8SMTP id 54D5F402F2 for ; Tue, 12 Aug 2025 12:04:46 +0200 (CEST) Date: Tue, 12 Aug 2025 12:04:46 +0200 Message-ID: <20250812120446.GB32174@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: References: <20250812090205.A5F4D68B0ED@ffbox0-bg.ffmpeg.org> <20250812113408.GB24045@haasn.xyz> <1bfcff88-d626-475b-a506-9d60feb5177e@gyani.pro> <20250812115108.GB29347@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 12 Aug 2025 11:53:20 +0200 Nicolas George wrote: > Niklas Haas (HE12025-08-12): > > I see that, but note: > > 1) the PR *was* approved > > How do you know that approval was worth anything? As far as my understanding goes, only people with write access to the repository status have the ability to merge or approve PRs. If you do not feel somebody can be trusted with write access, that is a separate issue irrelevant to this discussion. That aside, the person who reviewed the PR also has about 100x more activity than you in the past 2-year period and is also a member of the GA. I think it's fair to assume they are qualified to review a trivial patch. > > 2) nobody is listed as a maintainer for these filters > > So as a default, they are maintained by whoever maintains libavfilter as > a whole, which means me since Stefano took steps back from development. Where in "MAINTAINERS" is this written? > Technical solution will not solve human problems. Having a clearly defined process is a human solution to a human problem. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".