From: Niklas Haas <ffmpeg@haasn.xyz>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging
Date: Tue, 12 Aug 2025 12:04:46 +0200
Message-ID: <20250812120446.GB32174@haasn.xyz> (raw)
In-Reply-To: <aJsPEFqNgDHqwPTi@phare.normalesup.org>
On Tue, 12 Aug 2025 11:53:20 +0200 Nicolas George <george@nsup.org> wrote:
> Niklas Haas (HE12025-08-12):
> > I see that, but note:
> > 1) the PR *was* approved
>
> How do you know that approval was worth anything?
As far as my understanding goes, only people with write access to the
repository status have the ability to merge or approve PRs. If you do not
feel somebody can be trusted with write access, that is a separate issue
irrelevant to this discussion.
That aside, the person who reviewed the PR also has about 100x more activity
than you in the past 2-year period and is also a member of the GA. I think
it's fair to assume they are qualified to review a trivial patch.
> > 2) nobody is listed as a maintainer for these filters
>
> So as a default, they are maintained by whoever maintains libavfilter as
> a whole, which means me since Stefano took steps back from development.
Where in "MAINTAINERS" is this written?
> Technical solution will not solve human problems.
Having a clearly defined process is a human solution to a human problem.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-08-12 10:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250812090205.A5F4D68B0ED@ffbox0-bg.ffmpeg.org>
2025-08-12 9:16 ` Nicolas George
2025-08-12 9:34 ` Niklas Haas
2025-08-12 9:35 ` Niklas Haas
2025-08-12 9:38 ` Gyan Doshi
2025-08-12 9:51 ` Niklas Haas
2025-08-12 9:53 ` Nicolas George
2025-08-12 10:04 ` Niklas Haas [this message]
2025-08-12 17:20 ` Nicolas George
2025-08-12 15:57 ` James Almer
2025-08-12 17:13 ` Nicolas George
2025-08-12 12:35 ` Tristan Matthews via ffmpeg-devel
2025-08-12 15:59 ` Kacper Michajlow
2025-08-12 16:02 ` Niklas Haas
2025-08-12 16:15 ` Yalda
2025-08-12 17:08 ` Nicolas George
2025-08-12 17:24 ` Yalda
2025-08-12 9:50 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812120446.GB32174@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git