From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DD3474CF11 for ; Tue, 12 Aug 2025 09:34:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3819E68BA65; Tue, 12 Aug 2025 12:34:16 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9FEA168B53E for ; Tue, 12 Aug 2025 12:34:09 +0300 (EEST) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with UTF8SMTP id 19B4A402F2; Tue, 12 Aug 2025 11:34:09 +0200 (CEST) Date: Tue, 12 Aug 2025 11:34:08 +0200 Message-ID: <20250812113408.GB24045@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: References: <20250812090205.A5F4D68B0ED@ffbox0-bg.ffmpeg.org> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: michael@niedermayer.cc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 12 Aug 2025 11:16:19 +0200 Nicolas George wrote: > ffmpeg-git@ffmpeg.org (HE12025-08-12): > > Author: Niklas Haas > > AuthorDate: Mon Aug 11 15:57:24 2025 +0200 > > Commit: Niklas Haas > > CommitDate: Tue Aug 12 09:01:39 2025 +0000 > > Pushing after less than 24 hours without approval by the maintainer is > absolutely unacceptable, forge or no forge, and a spit in my face for > the time I invested into starting to look at the code, thankfully > limited. In https://ffmpeg.org/developer.html#Patch-review-process it says: > After a patch is approved it will be committed to the repository. I don't see anything about a time-frame requirement here. That said, maybe we should adopt one, especially now that we actually receive reviews in a timely manner thanks to the adoption of forgejo. Perhaps we adopt the VLC model, which is: - If a PR has received no activity for 3 days - AND it has at least one approval - AND it passes all CI checks then it will be merged automatically, by a bot. > > Never do that again. > > -- > Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".