Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging
Date: Tue, 12 Aug 2025 11:34:08 +0200
Message-ID: <20250812113408.GB24045@haasn.xyz> (raw)
In-Reply-To: <aJsGYw51wpUVurHT@phare.normalesup.org>

On Tue, 12 Aug 2025 11:16:19 +0200 Nicolas George <george@nsup.org> wrote:
> ffmpeg-git@ffmpeg.org (HE12025-08-12):
> > Author:     Niklas Haas <git@haasn.dev>
> > AuthorDate: Mon Aug 11 15:57:24 2025 +0200
> > Commit:     Niklas Haas <ffmpeg@haasn.dev>
> > CommitDate: Tue Aug 12 09:01:39 2025 +0000
>
> Pushing after less than 24 hours without approval by the maintainer is
> absolutely unacceptable, forge or no forge, and a spit in my face for
> the time I invested into starting to look at the code, thankfully
> limited.

In https://ffmpeg.org/developer.html#Patch-review-process it says:

> After a patch is approved it will be committed to the repository.

I don't see anything about a time-frame requirement here.

That said, maybe we should adopt one, especially now that we actually
receive reviews in a timely manner thanks to the adoption of forgejo.

Perhaps we adopt the VLC model, which is:
- If a PR has received no activity for 3 days
- AND it has at least one approval
- AND it passes all CI checks
then it will be merged automatically, by a bot.

>
> Never do that again.
>
> --
>   Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".