[FFmpeg-devel] [PATCH] libavutil/tests/lzo: Add check to avoid potential NULL pointer dereference

[FFmpeg-devel] [PATCH] libavutil/tests/lzo: Add check to avoid potential NULL pointer dereference

[Jiasheng Jiang]

Add av_free() if qf_vid is NULL to avoid potential memory leak.

Fixes: 5d48e4eafa ("Merge commit 'a6a750c7ef240b72ce01e9653343a0ddf247d196'")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 libavutil/tests/lzo.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libavutil/tests/lzo.c b/libavutil/tests/lzo.c
index d7a78a1696..89e504601a 100644
--- a/libavutil/tests/lzo.c
+++ b/libavutil/tests/lzo.c
@@ -45,6 +45,10 @@ int main(int argc, char *argv[]) {
     long tmp[LZO1X_MEM_COMPRESS];
     int inlen, outlen;
     int i;
+
+    if (!in || !orig || !comp || !decomp)
+        goto end;
+
     av_log_set_level(AV_LOG_DEBUG);
     if (comp_level == 0) {
         lzo1x_1_compress(orig, s, comp, &clen, tmp);
@@ -71,6 +75,8 @@ int main(int argc, char *argv[]) {
         av_log(NULL, AV_LOG_ERROR, "decompression incorrect\n");
     else
         av_log(NULL, AV_LOG_ERROR, "decompression OK\n");
+
+end:
     fclose(in);
     av_free(orig);
     av_free(comp);
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavutil/tests/lzo: Add check to avoid potential NULL pointer dereference

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1307 bytes --]

On Fri, Aug 08, 2025 at 02:08:42AM +0000, Jiasheng Jiang wrote:
> Add av_free() if qf_vid is NULL to avoid potential memory leak.
> 
> Fixes: 5d48e4eafa ("Merge commit 'a6a750c7ef240b72ce01e9653343a0ddf247d196'")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
>  libavutil/tests/lzo.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/libavutil/tests/lzo.c b/libavutil/tests/lzo.c
> index d7a78a1696..89e504601a 100644
> --- a/libavutil/tests/lzo.c
> +++ b/libavutil/tests/lzo.c
> @@ -45,6 +45,10 @@ int main(int argc, char *argv[]) {
>      long tmp[LZO1X_MEM_COMPRESS];
>      int inlen, outlen;
>      int i;
> +
> +    if (!in || !orig || !comp || !decomp)
> +        goto end;
> +
>      av_log_set_level(AV_LOG_DEBUG);
>      if (comp_level == 0) {
>          lzo1x_1_compress(orig, s, comp, &clen, tmp);
> @@ -71,6 +75,8 @@ int main(int argc, char *argv[]) {
>          av_log(NULL, AV_LOG_ERROR, "decompression incorrect\n");
>      else
>          av_log(NULL, AV_LOG_ERROR, "decompression OK\n");
> +
> +end:
>      fclose(in);

this could call flcose(NULL)

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".