On Sat, Aug 09, 2025 at 03:10:20AM +0000, Jiasheng Jiang wrote: > Add av_frame_free() to release frame to avoid potential memory leaks. > > Fixes: 5fdb5ed613 ("FATE: add a test for sliced scaling") > Signed-off-by: Jiasheng Jiang > --- > tools/scale_slice_test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/scale_slice_test.c b/tools/scale_slice_test.c > index 4480bf8569..a6b888090f 100644 > --- a/tools/scale_slice_test.c > +++ b/tools/scale_slice_test.c > @@ -157,6 +157,7 @@ int main(int argc, char **argv) > > ret = av_frame_get_buffer(frame, 0); > if (ret < 0) { > + av_frame_free(&frame); > fprintf(stderr, "Error allocating frame data\n"); > return ret; > } > @@ -173,6 +174,7 @@ int main(int argc, char **argv) > > ret = ds_open(&dc, filename, 0); > if (ret < 0) { > + av_frame_free(&frame); > fprintf(stderr, "Error opening the file\n"); > return ret; > } make -j32 fate-sws-slice-yuv422-12bit-rgb48 CC tools/scale_slice_test.o tools/scale_slice_test.c: In function ‘main’: tools/scale_slice_test.c:177:24: error: ‘frame’ undeclared (first use in this function) 177 | av_frame_free(&frame); | ^~~~~ tools/scale_slice_test.c:177:24: note: each undeclared identifier is reported only once for each function it appears in make: *** [ffbuild/common.mak:81: tools/scale_slice_test.o] Error 1 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt.