Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-test: Add proper error handling to avoid potential memory leaks

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-test: Add proper error handling to avoid potential memory leaks
Date: Mon, 11 Aug 2025 22:55:06 +0200
Message-ID: <20250811205506.GB29660@pb2> (raw)
In-Reply-To: <20250808192229.19078-1-jiashengjiangcool@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1163 bytes --]

On Fri, Aug 08, 2025 at 07:22:29PM +0000, Jiasheng Jiang wrote:
[...]
> @@ -69,44 +70,49 @@ static int video_decode_example(const char *input_filename)
>      codec = avcodec_find_decoder(origin_par->codec_id);
>      if (!codec) {
>          av_log(NULL, AV_LOG_ERROR, "Can't find decoder\n");
> -        return -1;
> +        result = -1;
> +        goto cloce_fmt_ctx;
>      }
>  
>      ctx = avcodec_alloc_context3(codec);
>      if (!ctx) {
>          av_log(NULL, AV_LOG_ERROR, "Can't allocate decoder context\n");
> -        return AVERROR(ENOMEM);
> +        result = AVERROR(ENOMEM);
> +        goto free_fmt_ctx;

make -j32  fate-api-h264
CC	tests/api/api-h264-test.o
tests/api/api-h264-test.c: In function ‘video_decode_example’:
tests/api/api-h264-test.c:81:9: error: label ‘free_fmt_ctx’ used but not defined
   81 |         goto free_fmt_ctx;
      |         ^~~~
make: *** [ffbuild/common.mak:81: tests/api/api-h264-test.o] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives. 
-- Abba Eban

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".