From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A82154CE40 for ; Mon, 11 Aug 2025 10:51:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6E84468BD1A; Mon, 11 Aug 2025 13:51:46 +0300 (EEST) Received: from relay15.mail.gandi.net (relay15.mail.gandi.net [217.70.178.235]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E052568AEB1 for ; Mon, 11 Aug 2025 13:51:39 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 271D243140 for ; Mon, 11 Aug 2025 10:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754909499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aBxLqRGX4NQQjCtZ7hErbtsKLBc3rp+N+xaUqg3Xwv4=; b=iY2ceYuX/4MffFzKmAWyhGBQA0D6eZ9kQFihjbmdlpAnzILqzDWLI0XmkCC8lXKnwY3HDc PV8UqZtfIorAXPouQqu6XeerfattzJ8BUC3Ds4m5IXzTd1rRqUT/X8sGcYU6LgHLdCK8Vu RPHB0oRIYC49Gj5d0Ekv+l30PQGi7YBSd/ulvGA40YIcJFTo/zJjtxVWLWpEyK75mWkExx 7GFiTOeScDSutdpXjP2u0k115aVaZ0D0FzmYAvkSYk1jk/EZfwrsk0cYxfKrB+6HheC5ln 1hz2oO/GRxzqsFquOJS3DM4X12m60gS5P+iJThd94QMcUJBGnaVYG6qiWwu7Xw== Date: Mon, 11 Aug 2025 12:51:38 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250811105138.GX29660@pb2> References: <20250811083755.CDB4D68BEE9@ffbox0-bg.ffmpeg.org> MIME-Version: 1.0 In-Reply-To: <20250811083755.CDB4D68BEE9@ffbox0-bg.ffmpeg.org> X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddufedvvdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeffledtfeevfeffheeuuefhtdejieelueeftdeitdfgheetgefffeefteekffdthfenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Subject: Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3010250181597607063==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3010250181597607063== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AZFWo7d0AbiSx4S+" Content-Disposition: inline --AZFWo7d0AbiSx4S+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 11, 2025 at 11:37:55AM +0300, quink wrote: > PR #20212 opened by quink > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212.patch >=20 > A set of files begins with the following byte sequence. >=20 > 00000000 4c 41 4d 45 33 2e 31 30 30 aa aa aa aa aa aa aa |LAME3.100...= =2E...| > 00000010 aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa |............= =2E...| > * >=20 > It seems they are encoded with lame, but missing header bytes at the > beginning. >=20 > Signed-off-by: Zhao Zhili >=20 >=20 > From e24f7b8d0fbc4295b3dfc9832d7b552086f45ff0 Mon Sep 17 00:00:00 2001 > From: Zhao Zhili > Date: Mon, 11 Aug 2025 15:23:36 +0800 > Subject: [PATCH] avformat/mp3dec: Workaround mp3 detection failure >=20 > A set of files begins with the following byte sequence. >=20 > 00000000 4c 41 4d 45 33 2e 31 30 30 aa aa aa aa aa aa aa |LAME3.100...= =2E...| > 00000010 aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa |............= =2E...| > * >=20 > It seems they are encoded with lame, but missing header bytes at the > beginning. >=20 > Signed-off-by: Zhao Zhili > --- > libavformat/mp3dec.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index 31eeb68ebb..fd692a9c76 100644 > --- a/libavformat/mp3dec.c > +++ b/libavformat/mp3dec.c > @@ -121,8 +121,11 @@ static int mp3_read_probe(const AVProbeData *p) > // issues with MPEG-files! > if (first_frames>=3D7) return AVPROBE_SCORE_EXTENSION + 1; > else if (max_frames>200 && p->buf_size < 2*max_framesizes)return AVP= ROBE_SCORE_EXTENSION; > - else if (max_frames>=3D4 && p->buf_size < 2*max_framesizes) return A= VPROBE_SCORE_EXTENSION / 2; > - else if (ff_id3v2_match(buf0, ID3v2_DEFAULT_MAGIC) && 2*ff_id3v2_tag= _len(buf0) >=3D p->buf_size) > + else if (max_frames>=3D4 && p->buf_size < 2*max_framesizes) { > + if (!memcmp(p->buf, "LAME3.100", sizeof("LAME3.100") - 1)) > + return AVPROBE_SCORE_EXTENSION - 2; > + return AVPROBE_SCORE_EXTENSION / 2; > + } else if (ff_id3v2_match(buf0, ID3v2_DEFAULT_MAGIC) && 2*ff_id3v2_t= ag_len(buf0) >=3D p->buf_size) why is this needed ? Naively i would expect that the probe code would detect a mp3 stream like t= his based on max_frames why does that fail ? as what is teh stream detected instead ? maybe whatever detects it, is wrong instead and can be improved by not miss= detecting it thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If the United States is serious about tackling the national security threat= s=20 related to an insecure 5G network, it needs to rethink the extent to which = it values corporate profits and government espionage over security.-Bruce Schn= eier --AZFWo7d0AbiSx4S+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaJnLNgAKCRBhHseHBAsP q9pCAJ9L3XYrsYXzB+PDxFsGBgYw/34vMgCfSfgTsuENVjCLhMuYh/fd1SyldJo= =ajKj -----END PGP SIGNATURE----- --AZFWo7d0AbiSx4S+-- --===============3010250181597607063== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3010250181597607063==--