From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4E6B74CDEB for ; Mon, 11 Aug 2025 08:03:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1FDD168D271; Mon, 11 Aug 2025 11:03:04 +0300 (EEST) Received: from 472d2aa5cb20 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8561C68BA60 for ; Mon, 11 Aug 2025 11:03:01 +0300 (EEST) MIME-Version: 1.0 From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] =?utf-8?q?=5BPATCH=5D_avfilter/vf=5Flibplacebo=3A?= =?utf-8?q?_fix_possible_segfault_when_frame_mixing_=28PR_=2320211=29?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-Id: <20250811080304.1FDD168D271@ffbox0-bg.ffmpeg.org> Date: Mon, 11 Aug 2025 11:03:04 +0300 (EEST) Archived-At: List-Archive: List-Post: PR #20211 opened by Niklas Haas (haasn) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20211 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20211.patch pl_frame_mix_current() will return NULL if all frames are in the future, but when libplacebo is using a frame mixer with a radius greater than 1, future frames are expected to already be partially renderered. Instead, use pl_frame_mix_nearest(), which is guaranteed to give us a valid frame for any nonempty frame mix. Fixes: 3091bca3edb339a4d2ec8c64e52fa7e67a7d5005 >From 5d70dc27c0198dbcf9843efd2145189cb0a89d26 Mon Sep 17 00:00:00 2001 From: Niklas Haas Date: Mon, 11 Aug 2025 09:58:58 +0200 Subject: [PATCH] avfilter/vf_libplacebo: fix possible segfault when frame mixing pl_frame_mix_current() will return NULL if all frames are in the future, but when libplacebo is using a frame mixer with a radius greater than 1, future frames are expected to already be partially renderered. Instead, use pl_frame_mix_nearest(), which is guaranteed to give us a valid frame for any nonempty frame mix. Fixes: 3091bca3edb339a4d2ec8c64e52fa7e67a7d5005 --- libavfilter/vf_libplacebo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 135749d3b1..01ce9d56b7 100644 --- a/libavfilter/vf_libplacebo.c +++ b/libavfilter/vf_libplacebo.c @@ -928,7 +928,8 @@ static int output_frame(AVFilterContext *ctx, int64_t pts) struct pl_frame dummy; if (in->qstatus != PL_QUEUE_OK || !in->mix.num_frames) continue; - const struct pl_frame *cur = pl_frame_mix_current(&in->mix); + const struct pl_frame *cur = pl_frame_mix_nearest(&in->mix); + av_assert1(cur); update_crops(ctx, in, &dummy, target_pts); const int x0 = roundf(FFMIN(dummy.crop.x0, dummy.crop.x1)), y0 = roundf(FFMIN(dummy.crop.y0, dummy.crop.y1)), -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".