From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 721D34CDC7 for ; Sun, 10 Aug 2025 02:45:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E2AC868BFFD; Sun, 10 Aug 2025 05:45:29 +0300 (EEST) Received: from 0f9ae49ae7c8 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0A328687C64 for ; Sun, 10 Aug 2025 05:45:28 +0300 (EEST) MIME-Version: 1.0 From: Leo Izen To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] =?utf-8?q?=5BPATCH=5D_avcodec/vp9=3A_fix_leaked_c?= =?utf-8?q?bs_fragment_AVBufferRef_=28PR_=2320205=29?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-Id: <20250810024529.E2AC868BFFD@ffbox0-bg.ffmpeg.org> Date: Sun, 10 Aug 2025 05:45:29 +0300 (EEST) Archived-At: List-Archive: List-Post: PR #20205 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20205 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20205.patch When this function returns, the fragment is never reset, so current_frag->data_ref is never unref-ed, which ends up leaking it. We call ff_cbs_reset_fragment to release the reference on its buffer. Signed-off-by: Leo Izen >From 8e15de6ceaa3c4599f6b47db68f478aa10299195 Mon Sep 17 00:00:00 2001 From: Leo Izen Date: Sat, 9 Aug 2025 22:41:22 -0400 Subject: [PATCH] avcodec/vp9: fix leaked cbs fragment AVBufferRef When this function returns, the fragment is never reset, so current_frag->data_ref is never unref-ed, which ends up leaking it. We call ff_cbs_reset_fragment to release the reference on its buffer. Signed-off-by: Leo Izen --- libavcodec/vp9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 47fabf98e3..d0d0238c2c 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -1679,8 +1679,6 @@ static int vp9_decode_frame(AVCodecContext *avctx, AVFrame *frame, &s->s.frames[CUR_FRAME] : &s->s.ref_frames[i]); } - ff_cbs_fragment_reset(&s->current_frag); - goto finish; } @@ -1805,6 +1803,8 @@ static int vp9_decode_frame(AVCodecContext *avctx, AVFrame *frame, } finish: + ff_cbs_fragment_reset(&s->current_frag); + ff_progress_frame_report(&s->s.frames[CUR_FRAME].tf, INT_MAX); // ref frame setup for (int i = 0; i < 8; i++) -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".