From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 76B544CD0A for ; Sun, 10 Aug 2025 00:47:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6C27D68CFF9; Sun, 10 Aug 2025 03:47:50 +0300 (EEST) Received: from 0f9ae49ae7c8 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8017B68CF2E for ; Sun, 10 Aug 2025 03:47:48 +0300 (EEST) MIME-Version: 1.0 From: Jack Lau To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] =?utf-8?q?=5BPATCH=5D_avformat/tls=5Fopenssl=3A_f?= =?utf-8?q?ix_X509_cert_serial_number_might_be_negative_=28PR_=2320203=29?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-Id: <20250810004750.6C27D68CFF9@ffbox0-bg.ffmpeg.org> Date: Sun, 10 Aug 2025 03:47:50 +0300 (EEST) Archived-At: List-Archive: List-Post: PR #20203 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20203 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20203.patch This patch was split from #20030 to make the patchset smaller and easier to review. >From 5b2c12716051b4935b9d41b0802e6b17c592ad1d Mon Sep 17 00:00:00 2001 From: winlin Date: Tue, 10 Jun 2025 14:53:08 -0400 Subject: [PATCH] avformat/tls_openssl: fix X509 cert serial number might be negative See RFC5280 4.1.2.2 Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 65b2966688..bab2e711c6 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -315,7 +315,8 @@ end: static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerprint) { - int ret = 0, serial, expire_day; + int ret = 0, expire_day; + uint64_t serial; const char *aor = "lavf"; X509_NAME* subject = NULL; @@ -330,8 +331,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri goto enomem_end; } - serial = (int)av_get_random_seed(); - if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) { + serial = av_get_random_seed(); + if (ASN1_INTEGER_set_uint64(X509_get_serialNumber(*cert), serial) != 1) { av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL)); goto einval_end; } -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".