From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9C3D54CD03 for ; Fri, 8 Aug 2025 23:29:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6A29868CD75; Sat, 9 Aug 2025 02:29:03 +0300 (EEST) Received: from relay16.mail.gandi.net (relay16.mail.gandi.net [217.70.178.236]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1912968C9CC for ; Sat, 9 Aug 2025 02:28:57 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5A99D43967 for ; Fri, 8 Aug 2025 23:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754695736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T/boF6fS/VN66j4RWdVYG9YP6e/gyWxtkxejhSBSBp0=; b=QSbtNvNZMBsc1XrV2vA8akY/AykVBbQ50qwEhmoD3F5wPINMv6w0HeeB2bLwwaJQuoZDq6 C/PFVc0VnYWYqWnJ6CSH5+LKJOMtzA1mOVRXDjlHV3yJVLpXjO+i5s8LGiFYr1ccUJ0+jT r2yl3VchDYVKn3qwRprBgHh3pMA/4qP7/SnOjaZHFbOba1RzjV2oxqBmfU0risZQYWReTr vQzjizbyh6hfU9fRrs/OEpeSUQwV9SCGb21epK9mJJ8vxQGr0crLkhsa50cR+4e82cS2z3 IU6dRwUlpiQyEkITutKuHmjpZ0yma5f84RlxLDuCK4maSuS2Pm6rQuEGOmraGA== Date: Sat, 9 Aug 2025 01:28:54 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250808232854.GQ29660@pb2> References: <20250808230948.GP29660@pb2> <6233111e-537c-4e30-8df4-f1651b9ee5f3@gmail.com> MIME-Version: 1.0 In-Reply-To: <6233111e-537c-4e30-8df4-f1651b9ee5f3@gmail.com> X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduvdehudefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeitdfgvedtfeekgfeuieejteeviedtveffueduudejhfejvdeuteeujeetvdeuueenucffohhmrghinhepfhhfmhhpvghgrdhorhhgpdhgihhthhhusgdrtghomhenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg Subject: Re: [FFmpeg-devel] rebase bugs? X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4261805596715787990==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4261805596715787990== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ER1mbRIZEUm3bYED" Content-Disposition: inline --ER1mbRIZEUm3bYED Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 08, 2025 at 08:18:43PM -0300, James Almer wrote: > On 8/8/2025 8:09 PM, Michael Niedermayer wrote: > > git log --grep "Clear state on alloc" origin/master --oneline > > 85a2beaa811 avcodec/ffv1: Clear state on alloc > > 70fc46d1856 avcodec/ffv1: Clear state on alloc >=20 > Yeah, that's not good. The second commit is an empty duplicate. but how did this happen ? the webpage lists 70fc46d185 (https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/2= 0134) is this some sort multithreading feature where it spwns independant workers for each and then maybe end up with 2 for one pr ? iam just speculating i h= ave not looked at one single line of forgejo code if thats the case it should have stoped when it realized the comits are emp= ty >=20 > >=20 > > also not signed, not even with forgejos key: > It only signs commits if they were signed in the PR prior to rebasing, i > think. git log fforge/pr/20134 -2 --show-signature commit a99fa230adbe52504e6fadc1a3f85b5c30154349 (fforge/pr/20134, fforge-mi= chaelni/ff-tmp-uninit-ut-vlc-ffv1) gpg: Signature made Thu 07 Aug 2025 06:33:14 PM CEST gpg: using EDDSA key DD1EC9E8DE085C629B3E1846B18E8928B3948D64 gpg: Good signature from "Michael Niedermayer "= [ultimate] gpg: aka "Michael Niedermayer (key used for git commits) " [ultimate] Author: Michael Niedermayer Date: Wed Aug 6 13:36:06 2025 +0200 avcodec/ffv1: Clear state on alloc Fixes: use of uninitialized memory Fixes: 428969823/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1= _DEC_fuzzer-5909681623334912 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer commit 006125030a0c360539c615fa6b5881c9bd78e637 gpg: Signature made Thu 07 Aug 2025 06:33:13 PM CEST gpg: using EDDSA key DD1EC9E8DE085C629B3E1846B18E8928B3948D64 gpg: Good signature from "Michael Niedermayer "= [ultimate] gpg: aka "Michael Niedermayer (key used for git commits) " [ultimate] Author: Michael Niedermayer Date: Wed Aug 6 13:09:26 2025 +0200 avcodec/utvideodec: Set B for the width=3D 1 case Fixes: use of uninitialized meory Fixes: 428034093/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_UTVI= DEO_DEC_fuzzer-6195630160805888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer btw: (not sure thats the same issue or a genuine typo, its not empty seem l= ike a genuine typo) git log -2 8b5db38dc6d commit 8b5db38dc6d0bec05ce7e4c1451986055032ed9c Author: Kacper Michaj=C5=82ow Date: Sat Jul 26 05:00:11 2025 +0200 avcodec/qcelpdec: set missing sample rate Commit f566032bfda2fee4fb6388d5906d1957a1ed868a added frame validation. Since then this decoder has been failing validation of sample rate value. Found by OSS-Fuzz. Signed-off-by: Kacper Michaj=C5=82ow commit 7f5db34f3b02ea5c1a951e65f04e313841ee888e Author: Kacper Michaj=C5=82ow Date: Sat Jul 26 04:59:44 2025 +0200 avcodec/qcelpdec: set missing sample rate Commit f566032bfda2fee4fb6388d5906d1957a1ed868a added frame validation. Since then this decoder has been failing validation of sample rate value. Found by OSS-Fuzz. Signed-off-by: Kacper Michaj=C5=82ow [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates --ER1mbRIZEUm3bYED Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaJaIMgAKCRBhHseHBAsP q0yFAJ9jbJwH5wP7yn2rvHck2rfvumCRowCgl1kBwadQj9dZaj8BdEaiMjEDyII= =puKE -----END PGP SIGNATURE----- --ER1mbRIZEUm3bYED-- --===============4261805596715787990== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4261805596715787990==--