From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9DBD04CBE1 for ; Fri, 8 Aug 2025 15:00:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1404F68CA66; Fri, 8 Aug 2025 18:00:10 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id CD294687CB5 for ; Fri, 8 Aug 2025 18:00:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CC18A442C7 for ; Fri, 8 Aug 2025 15:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754665203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LRTjDOjKnY3j6e/F5ifSKtUTquPaqFXRdXe1N2owbmQ=; b=Cjs/jntqwi5CTr38TSdi3pve44i/NjDhIfu0e+07VmZrV4uE/Swg5BxDxXZRExa3UUDmr8 1q3Wx+LHaCL8eD49ieUyxQ/pF2FQfm85TKsF7xvJLYFCocDBKoHLlInzamyGMXcbeBuPN3 4NO60I1xlCaoM+ncxo4cxOflfjna+xJ6UhzGPKaCNiBw45j6xSv9zBlqQ9iQr940rYt2vR y2lmNlC82imiT7cVxraAbPRdZt/bHTRse4QXxz5jrBgxq6EtZ2EAoflLIxcxBK/ebv1jJv P69g25TbULZhkZ6KGdvqXyFTEKDGLlXlVUDf2w+kd7BEtXgQILMAtrGvbNikwg== Date: Fri, 8 Aug 2025 16:59:59 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250808145959.GL29660@pb2> References: <20250808132828.GI29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduvdeguddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeuveeukeeuieekffelieffgeefleehuefguefglefgvdeglefhieelgeefieekveenucffohhmrghinhepohhsshdqfhhuiiiirdgtohhmpdhffhhmphgvghdrohhrghenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [RFC] AAC (USAC) bug X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5159642877095757980==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5159642877095757980== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WvbBJB+StNFufZv+" Content-Disposition: inline --WvbBJB+StNFufZv+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Fri, Aug 08, 2025 at 10:36:48AM -0300, James Almer wrote: > On 8/8/2025 10:28 AM, Michael Niedermayer wrote: > > Hi > >=20 > > AAC USAC conatains a double free since 6 month > > (https://issues.oss-fuzz.com/issues/393523547) > >=20 > > A WIP fix is here: >=20 > WIP how? Is it incomplete? Andreas said this: "Unchecked allocation. Furthermore, the *dst =3D *src makes cleanup on error here a PITA. Would making pl_data reference-counted (via RefStruct) work instead?" I hoped someone would implement the RefStruct stuff. I didnt anticipate noone would even reply multiple pings >=20 > > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339564.ht= ml > >=20 > > what do people prefer here to be done ? > > should we delay the release until someone fixes this ? >=20 > If the above fix works, then it can be applied until a better one is done It would be needed to make sure teh issue Andreas raised is dealt with either with or without RefStruct. when I asked in that thread if others wanted to work on this i wouldnt at the same time start working on it (that would be duplicate work potentially) and then i of course forgot as noone even said "No" > (Lynne owns this code, so she should probably look at it). that would be very good, yes thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The day soldiers stop bringing you their problems is the day you have stopp= ed=20 leading them. They have either lost confidence that you can help or conclud= ed=20 you do not care. Either case is a failure of leadership. - Colin Powell --WvbBJB+StNFufZv+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaJYQ6wAKCRBhHseHBAsP q7LNAJ4yR/QrJ7pTLZNmlKiD7e6Krme30wCggrb6KJOd5iUQDimRw6EtGL1jLBM= =efHt -----END PGP SIGNATURE----- --WvbBJB+StNFufZv+-- --===============5159642877095757980== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5159642877095757980==--