From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC] AAC (USAC) bug
Date: Fri, 8 Aug 2025 16:59:59 +0200
Message-ID: <20250808145959.GL29660@pb2> (raw)
In-Reply-To: <d64de1bc-ba26-4df9-88b7-0053599ce783@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1626 bytes --]
Hi
On Fri, Aug 08, 2025 at 10:36:48AM -0300, James Almer wrote:
> On 8/8/2025 10:28 AM, Michael Niedermayer wrote:
> > Hi
> >
> > AAC USAC conatains a double free since 6 month
> > (https://issues.oss-fuzz.com/issues/393523547)
> >
> > A WIP fix is here:
>
> WIP how? Is it incomplete?
Andreas said this:
"Unchecked allocation. Furthermore, the *dst = *src makes cleanup on
error here a PITA. Would making pl_data reference-counted (via
RefStruct) work instead?"
I hoped someone would implement the RefStruct stuff. I didnt anticipate
noone would even reply multiple pings
>
> > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339564.html
> >
> > what do people prefer here to be done ?
> > should we delay the release until someone fixes this ?
>
> If the above fix works, then it can be applied until a better one is done
It would be needed to make sure teh issue Andreas raised is dealt with
either with or without RefStruct.
when I asked in that thread if others wanted to work on this i wouldnt
at the same time start working on it (that would be duplicate work
potentially) and then i of course forgot as noone even said "No"
> (Lynne owns this code, so she should probably look at it).
that would be very good, yes
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The day soldiers stop bringing you their problems is the day you have stopped
leading them. They have either lost confidence that you can help or concluded
you do not care. Either case is a failure of leadership. - Colin Powell
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-08-08 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 13:28 Michael Niedermayer
2025-08-08 13:33 ` Michael Niedermayer
2025-08-08 13:38 ` Michael Niedermayer
2025-08-08 13:36 ` James Almer
2025-08-08 14:59 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808145959.GL29660@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git