[FFmpeg-devel] [RFC] AAC (USAC) bug

[FFmpeg-devel] [RFC] AAC (USAC) bug

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 489 bytes --]

Hi

AAC USAC conatains a double free since 6 month
(https://issues.oss-fuzz.com/issues/393523547)

A WIP fix is here:
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339564.html

what do people prefer here to be done ?
should we delay the release until someone fixes this ?

thx

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is a danger to trust the dream we wish for rather than
the science we have, -- Dr. Kenneth Brown

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] AAC (USAC) bug

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 541 bytes --]

On Fri, Aug 08, 2025 at 03:28:28PM +0200, Michael Niedermayer wrote:
> Hi
> 
> AAC USAC conatains a double free since 6 month
> (https://issues.oss-fuzz.com/issues/393523547)

this is possibly a duplicate of this:
https://issues.oss-fuzz.com/issues/394371775

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] AAC (USAC) bug

[James Almer]

[-- Attachment #1.1.1: Type: text/plain, Size: 833 bytes --]

On 8/8/2025 10:28 AM, Michael Niedermayer wrote:
> Hi
> 
> AAC USAC conatains a double free since 6 month
> (https://issues.oss-fuzz.com/issues/393523547)
> 
> A WIP fix is here:

WIP how? Is it incomplete?

> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339564.html
> 
> what do people prefer here to be done ?
> should we delay the release until someone fixes this ?

If the above fix works, then it can be applied until a better one is 
done (Lynne owns this code, so she should probably look at it).

> 
> thx
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] AAC (USAC) bug

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 714 bytes --]

On Fri, Aug 08, 2025 at 03:33:15PM +0200, Michael Niedermayer wrote:
> On Fri, Aug 08, 2025 at 03:28:28PM +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > AAC USAC conatains a double free since 6 month
> > (https://issues.oss-fuzz.com/issues/393523547)
> 
> this is possibly a duplicate of this:
> https://issues.oss-fuzz.com/issues/394371775

also it appears there are a half dozen testcases grouped into
these as "related", if these turn out unrelated then once this is fixed they
will appear as new issues

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] AAC (USAC) bug

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1626 bytes --]

Hi

On Fri, Aug 08, 2025 at 10:36:48AM -0300, James Almer wrote:
> On 8/8/2025 10:28 AM, Michael Niedermayer wrote:
> > Hi
> > 
> > AAC USAC conatains a double free since 6 month
> > (https://issues.oss-fuzz.com/issues/393523547)
> > 
> > A WIP fix is here:
> 
> WIP how? Is it incomplete?

Andreas said this:
"Unchecked allocation. Furthermore, the *dst = *src makes cleanup on
 error here a PITA. Would making pl_data reference-counted (via
 RefStruct) work instead?"

I hoped someone would implement the RefStruct stuff. I didnt anticipate
noone would even reply multiple pings


> 
> > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339564.html
> > 
> > what do people prefer here to be done ?
> > should we delay the release until someone fixes this ?
> 
> If the above fix works, then it can be applied until a better one is done

It would be needed to make sure teh issue Andreas raised is dealt with
either with or without RefStruct.

when I asked in that thread if others wanted to work on this i wouldnt
at the same time start working on it (that would be duplicate work
potentially) and then i of course forgot as noone even said "No"


> (Lynne owns this code, so she should probably look at it).

that would be very good, yes

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The day soldiers stop bringing you their problems is the day you have stopped 
leading them. They have either lost confidence that you can help or concluded 
you do not care. Either case is a failure of leadership. - Colin Powell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".