From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7C9374CB9C for ; Fri, 8 Aug 2025 11:28:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3BBFE68C4D1; Fri, 8 Aug 2025 14:28:12 +0300 (EEST) Received: from 0f9ae49ae7c8 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D45DD68C4D1 for ; Fri, 8 Aug 2025 14:28:09 +0300 (EEST) MIME-Version: 1.0 From: nowrep To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] =?utf-8?q?=5BPATCH=5D_vulkan=5Fencode=5Fav1=3A_Fi?= =?utf-8?q?x_setting_QP_=28PR_=2320174=29?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-Id: <20250808112812.3BBFE68C4D1@ffbox0-bg.ffmpeg.org> Date: Fri, 8 Aug 2025 14:28:12 +0300 (EEST) Archived-At: List-Archive: List-Post: PR #20174 opened by nowrep URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20174 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20174.patch Use the "qp" param instead of "global_quality" to match H264/5. Note: Currently all codecs use the min QP as default value when no `qp` param has been set. It should instead pick some sane value, and maybe also print warning as VAAPI does. >From eb826726b8b971573f805365b22487b35089f9a0 Mon Sep 17 00:00:00 2001 From: David Rosca Date: Fri, 8 Aug 2025 13:19:29 +0200 Subject: [PATCH] vulkan_encode_av1: Fix setting QP Use the "qp" param instead of "global_quality" to match H264/5. --- libavcodec/vulkan_encode_av1.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vulkan_encode_av1.c b/libavcodec/vulkan_encode_av1.c index 83a8734c93..db70b2dc29 100644 --- a/libavcodec/vulkan_encode_av1.c +++ b/libavcodec/vulkan_encode_av1.c @@ -675,9 +675,9 @@ static int init_enc_options(AVCodecContext *avctx) enc->initial_buffer_fullness = enc->hrd_buffer_size * 3 / 4; } - if (enc->common.opts.rc_mode == VK_VIDEO_ENCODE_RATE_CONTROL_MODE_DISABLED_BIT_KHR && - avctx->global_quality) { - enc->q_idx_p = av_clip_intp2(avctx->global_quality / FF_QP2LAMBDA, 8); + if (enc->common.opts.rc_mode == VK_VIDEO_ENCODE_RATE_CONTROL_MODE_DISABLED_BIT_KHR) { + enc->q_idx_p = av_clip(enc->common.opts.qp, + enc->caps.minQIndex, enc->caps.maxQIndex); if (fabs(avctx->i_quant_factor) > 0.0) enc->q_idx_idr = av_clip((fabs(avctx->i_quant_factor) * enc->q_idx_p + -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".