[FFmpeg-devel] [PATCH] vulkan_encode: Remove unneeded VkImageUsageFlags (PR #20170)

[FFmpeg-devel] [PATCH] vulkan_encode: Remove unneeded VkImageUsageFlags (PR #20170)

[bcheng]

PR #20170 opened by bcheng
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20170
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20170.patch

There is no point where we need to have the SAMPLED usage on the DPB
resource, and the ENCODE_DST usage does not mean anything.


From ac995d2fc71405259085a107eb8a9d47bc464853 Mon Sep 17 00:00:00 2001
From: Benjamin Cheng <ben@bcheng.me>
Date: Thu, 7 Aug 2025 23:33:23 -0400
Subject: [PATCH] vulkan_encode: Remove unneeded VkImageUsageFlags

There is no point where we need to have the SAMPLED usage on the DPB
resource, and the ENCODE_DST usage does not mean anything.
---
 libavcodec/vulkan_encode.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/libavcodec/vulkan_encode.c b/libavcodec/vulkan_encode.c
index 122dd34f4c..e5c0496f1c 100644
--- a/libavcodec/vulkan_encode.c
+++ b/libavcodec/vulkan_encode.c
@@ -570,8 +570,7 @@ static int vulkan_encode_create_dpb(AVCodecContext *avctx, FFVulkanEncodeContext
     hwfc->format[0]    = ctx->pic_format;
     hwfc->create_pnext = &ctx->profile_list;
     hwfc->tiling       = VK_IMAGE_TILING_OPTIMAL;
-    hwfc->usage        = VK_IMAGE_USAGE_SAMPLED_BIT              |
-                         VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR;
+    hwfc->usage        = VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR;
 
     if (ctx->common.layered_dpb)
         hwfc->nb_layers = ctx->caps.maxDpbSlots;
@@ -931,8 +930,7 @@ av_cold int ff_vulkan_encode_init(AVCodecContext *avctx, FFVulkanEncodeContext *
         return AVERROR(EINVAL);
     }
 
-    fmt_info.imageUsage = VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR |
-                          VK_IMAGE_USAGE_VIDEO_ENCODE_DST_BIT_KHR;
+    fmt_info.imageUsage = VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR;
 
     ctx->common.layered_dpb = !(ctx->caps.flags & VK_VIDEO_CAPABILITY_SEPARATE_REFERENCE_IMAGES_BIT_KHR);
 
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".