From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8EF664CB60 for ; Fri, 8 Aug 2025 03:40:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 840C368C3EF; Fri, 8 Aug 2025 06:40:28 +0300 (EEST) Received: from 0f9ae49ae7c8 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B6712687ABE for ; Fri, 8 Aug 2025 06:40:26 +0300 (EEST) MIME-Version: 1.0 From: bcheng To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] =?utf-8?q?=5BPATCH=5D_vulkan=5Fencode=3A_Remove_u?= =?utf-8?q?nneeded_VkImageUsageFlags_=28PR_=2320170=29?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-Id: <20250808034028.840C368C3EF@ffbox0-bg.ffmpeg.org> Date: Fri, 8 Aug 2025 06:40:28 +0300 (EEST) Archived-At: List-Archive: List-Post: PR #20170 opened by bcheng URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20170 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20170.patch There is no point where we need to have the SAMPLED usage on the DPB resource, and the ENCODE_DST usage does not mean anything. >From ac995d2fc71405259085a107eb8a9d47bc464853 Mon Sep 17 00:00:00 2001 From: Benjamin Cheng Date: Thu, 7 Aug 2025 23:33:23 -0400 Subject: [PATCH] vulkan_encode: Remove unneeded VkImageUsageFlags There is no point where we need to have the SAMPLED usage on the DPB resource, and the ENCODE_DST usage does not mean anything. --- libavcodec/vulkan_encode.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/vulkan_encode.c b/libavcodec/vulkan_encode.c index 122dd34f4c..e5c0496f1c 100644 --- a/libavcodec/vulkan_encode.c +++ b/libavcodec/vulkan_encode.c @@ -570,8 +570,7 @@ static int vulkan_encode_create_dpb(AVCodecContext *avctx, FFVulkanEncodeContext hwfc->format[0] = ctx->pic_format; hwfc->create_pnext = &ctx->profile_list; hwfc->tiling = VK_IMAGE_TILING_OPTIMAL; - hwfc->usage = VK_IMAGE_USAGE_SAMPLED_BIT | - VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR; + hwfc->usage = VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR; if (ctx->common.layered_dpb) hwfc->nb_layers = ctx->caps.maxDpbSlots; @@ -931,8 +930,7 @@ av_cold int ff_vulkan_encode_init(AVCodecContext *avctx, FFVulkanEncodeContext * return AVERROR(EINVAL); } - fmt_info.imageUsage = VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR | - VK_IMAGE_USAGE_VIDEO_ENCODE_DST_BIT_KHR; + fmt_info.imageUsage = VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR; ctx->common.layered_dpb = !(ctx->caps.flags & VK_VIDEO_CAPABILITY_SEPARATE_REFERENCE_IMAGES_BIT_KHR); -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".