Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: [FFmpeg-devel] [PATCH] libswscale/tests/colorspace: Add av_free() to avoid potential memory leak
Date: Fri,  8 Aug 2025 02:30:05 +0000
Message-ID: <20250808023005.33565-1-jiashengjiangcool@gmail.com> (raw)

Add av_free() to avoid potential memory leak.

Fixes: 3a74415d59 ("cosmetics, expand all tabs to four spaces.")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 libswscale/tests/colorspace.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/libswscale/tests/colorspace.c b/libswscale/tests/colorspace.c
index d1eddc82bf..d0fd03a03b 100644
--- a/libswscale/tests/colorspace.c
+++ b/libswscale/tests/colorspace.c
@@ -41,9 +41,12 @@ int main(int argc, char **argv)
     uint8_t *dstBuffer = av_malloc(SIZE);
     int failedNum      = 0;
     int passedNum      = 0;
+    int ret;
 
-    if (!srcBuffer || !dstBuffer)
-        return -1;
+    if (!srcBuffer || !dstBuffer) {
+        ret = -1;
+        goto end;
+    }
 
     av_log(NULL, AV_LOG_INFO, "memory corruption test ...\n");
     ff_sws_rgb2rgb_init();
@@ -167,5 +170,10 @@ int main(int argc, char **argv)
     av_log(NULL, AV_LOG_INFO,
            "\n%d converters passed, %d converters randomly overwrote memory\n",
            passedNum, failedNum);
-    return failedNum;
+    ret = failedNum;
+
+err:
+    av_free(srcBuffer);
+    av_free(dstBuffer);
+    return ret;
 }
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

                 reply	other threads:[~2025-08-08  2:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250808023005.33565-1-jiashengjiangcool@gmail.com \
    --to=jiashengjiangcool@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git