From: michaelni <code@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] avcodec/apv_decode: Check that tiles are within the frame (PR #20168)
Date: Fri, 8 Aug 2025 02:38:17 +0300 (EEST)
Message-ID: <20250807233817.F184068CC39@ffbox0-bg.ffmpeg.org> (raw)
PR #20168 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20168
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20168.patch
Fixes: crash (out of array access)
Fixes: 435489659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APV_fuzzer-6194885205229568
CC: Mark Thompson <sw@jkqxz.net>
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
From 7f56ae1a62601392fac06483c538fc53b8bfe14c Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <michael@niedermayer.cc>
Date: Fri, 8 Aug 2025 01:05:05 +0200
Subject: [PATCH] avcodec/apv_decode: Check that tiles are within the frame
Fixes: crash (out of array access)
Fixes: 435489659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APV_fuzzer-6194885205229568
CC: Mark Thompson <sw@jkqxz.net>
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/apv_decode.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavcodec/apv_decode.c b/libavcodec/apv_decode.c
index eb47298e2e..4b0d9eb357 100644
--- a/libavcodec/apv_decode.c
+++ b/libavcodec/apv_decode.c
@@ -306,6 +306,10 @@ static int apv_decode(AVCodecContext *avctx, AVFrame *output,
return err;
}
+ if ( tile_info->col_starts[tile_info->tile_cols] > FFALIGN(avctx->width , APV_MB_WIDTH)
+ || tile_info->row_starts[tile_info->tile_rows] > FFALIGN(avctx->height, APV_MB_HEIGHT))
+ return AVERROR_INVALIDDATA;
+
err = ff_thread_get_buffer(avctx, output, 0);
if (err < 0)
return err;
--
2.49.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-08-07 23:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807233817.F184068CC39@ffbox0-bg.ffmpeg.org \
--to=code@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git