From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Add check for av_mallocz() to avoid potential NULL pointer dereference
Date: Thu, 7 Aug 2025 19:02:39 +0000
Message-ID: <20250807190239.5740-1-jiashengjiangcool@gmail.com> (raw)
Add check for the return value of av_mallocz() to avoid potential NULL pointer dereference.
Fixes: 1eeb59a209 ("avfilter/vf_drawtext: improve glyph shaping and positioning")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
libavfilter/vf_drawtext.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
index 674e1e53c1..2eb144b5bf 100644
--- a/libavfilter/vf_drawtext.c
+++ b/libavfilter/vf_drawtext.c
@@ -1437,6 +1437,11 @@ continue_on_failed:
s->line_count = line_count;
s->lines = av_mallocz(line_count * sizeof(TextLine));
s->tab_clusters = av_mallocz(s->tab_count * sizeof(uint32_t));
+ if (!s->lines || !s->tab_clusters) {
+ ret = AVERROR(ENOMEM);
+ goto done;
+ }
+
for (i = 0; i < s->tab_count; ++i) {
s->tab_clusters[i] = -1;
}
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-08-07 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 19:02 Jiasheng Jiang [this message]
2025-08-07 19:05 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807190239.5740-1-jiashengjiangcool@gmail.com \
--to=jiashengjiangcool@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git