From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9035D4CA74 for ; Thu, 7 Aug 2025 15:28:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B9D0468CDAA; Thu, 7 Aug 2025 18:27:58 +0300 (EEST) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2BC0B68CB82 for ; Thu, 7 Aug 2025 18:27:52 +0300 (EEST) Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-87999c368e9so91189239f.0 for ; Thu, 07 Aug 2025 08:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754580469; x=1755185269; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AzaIUuacUReIvOdYUD2nxdZ2NjGLm6CKMBi0dDRTdss=; b=UeOQ1CeELqPBIWRG9DKgeQr65GZAcC6EQZ9gQCD51y07D44WIpOPgvjO0Eym+61d/s Afju7wTiIb3SrHmTnT5T0GpbUdo75XasZjhGA9uvqSzxz4NK0BEaoo0XQjJ8ZObM2nwd awGlqVEleX8+4a7bB+w79AUgFDUNfGuQRq0pNdXSKJ4LRuALRaOQZSfXjIaSwt8Fc2/D s2eLAgfjNyyQPZeYIIRTPEL39XRZpAhP1+erAIZl+TxLrGub9YkUCLVE6ZlMpd2Vw57D 49U47Y55lrGAh/uqcdSn4FAu8odr2KtmE8WWOP5MzKjGw/mp7I0pkkIqbFUEcT2QiYQh hSww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754580469; x=1755185269; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AzaIUuacUReIvOdYUD2nxdZ2NjGLm6CKMBi0dDRTdss=; b=o2YtLgLqIJovdfOmOS6hdMyRXh2XTRH540hnRCBvYqlOUoG3q8+LavGkToEmeP+E9b zPTZtWfx3xRDncw82kwUNsyGojLYH7+Yp+yTTMJLj69xAcv+0X8cUv5zxCY3krNoSH4q P78smPyVBApr0zBNYhjnUrus1ty0N7XyNHu7fiexChMBIMRMrs2w9b7QwmSiH9YH2WGk 2usCeiHRpaskWL5++xJMvsZlU9HQX3PkGUTh27x7Xb/NYXUZdemNhPOKoXlX8EPyjC7g MbTbftmgJMhunByEs+zDEmy768jq9aPM3QS3N7OejYnPCRb7JuduWI05a3rQIW+56fHS uG1Q== X-Gm-Message-State: AOJu0YxsJ8N/iBpwa2BXIFBsDjn3Gm6bXAcLOrDk3YFMAkntMQUwjdqS XD4fpxvl0djIK8WYSPY7bv7SE5TgLOOsmoeoMEacp7TUNL+hRYy7w32txSF+pA== X-Gm-Gg: ASbGncuu52+WoXaMtY+VO26y7Gko2s5ak8oEPi1wB/vdaOxB6vMNReMOCKshVK4pLts zi3CWyFkz9CD5Vs5A2IMQqPg2rgBks6AsXmAoE/fGZO1kYHKd8JVoBZb4DE0Sf7rSen8o18X7xO qYv/2PzsFgrTLMpc3BOPImd2uMbOsUBICKVPL4Jnr+CDuwgVyBSwH949uvt1DizzUDn40lUR4pH kex45PtVGMr3JmZceKN7j00DjlgsH6cu9fopVpP3Sc4s0TX4WL7EJ1r5dF4fXJsNqQkhwX1qvZB M+VTmk1Ql2dp7a3bkHxFTVIJab9w5L5TmlvbCVASzRp1lyTb2/otaK0tqXN0kpKtIVyiAF3gei2 G5Om8B8E2tzdKppxoIcnOUju70zxwHeRxVXx7wpX7wSIH X-Google-Smtp-Source: AGHT+IHpmlacNS+zvZ2DATC+MLT5kssi4EE/mgxCH3G0HVSNkkPgfLrPho+LqpvBTAJoFHHvsO/Grw== X-Received: by 2002:a05:6602:14cf:b0:881:758b:802c with SMTP id ca18e2360f4ac-8819f3d77famr1126938239f.10.1754580468560; Thu, 07 Aug 2025 08:27:48 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50a998d23e5sm3449552173.33.2025.08.07.08.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Aug 2025 08:27:47 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Thu, 7 Aug 2025 15:27:45 +0000 Message-Id: <20250807152745.48050-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavfilter/qsvvpp: Add av_frame_free() to avoid potential memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add av_frame_free() in the error paths to avoid potential memory leak. Fixes: a5a6ac1a12 ("libavfilter/overlay_qsv: Add QSV overlay vpp filter") Signed-off-by: Jiasheng Jiang --- libavfilter/qsvvpp.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index c3685f126c..5d7fbb7f21 100644 --- a/libavfilter/qsvvpp.c +++ b/libavfilter/qsvvpp.c @@ -494,6 +494,7 @@ static QSVFrame *query_frame(QSVVPPContext *s, AVFilterLink *outlink, const AVFr ret = av_hwframe_get_buffer(l->hw_frames_ctx, out_frame->frame, 0); if (ret < 0) { + av_frame_free(&out_frame->frame); av_log(ctx, AV_LOG_ERROR, "Can't allocate a surface.\n"); return NULL; } @@ -505,13 +506,17 @@ static QSVFrame *query_frame(QSVVPPContext *s, AVFilterLink *outlink, const AVFr out_frame->frame = ff_get_video_buffer(outlink, FFALIGN(outlink->w, 128), FFALIGN(outlink->h, 64)); - if (!out_frame->frame) + if (!out_frame->frame) { + av_frame_free(&out_frame->frame); return NULL; + } ret = map_frame_to_surface(out_frame->frame, &out_frame->surface); - if (ret < 0) + if (ret < 0) { + av_frame_free(&out_frame->frame); return NULL; + } } if (propref) { -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".