From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: [FFmpeg-devel] [PATCH] libavfilter/avf_showcqt: Add check for av_calloc()
Date: Thu, 7 Aug 2025 02:34:23 +0000
Message-ID: <20250807023423.38303-1-jiashengjiangcool@gmail.com> (raw)
Add check for the return value of av_calloc() to avoid potential NULL pointer dereference.
Fixes: 0068b3d0f0 ("avfilter/avf_showcqt: switch to TX FFT from avutil")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
libavfilter/avf_showcqt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c
index f6a867a0ce..e1fc1c0259 100644
--- a/libavfilter/avf_showcqt.c
+++ b/libavfilter/avf_showcqt.c
@@ -1383,7 +1383,7 @@ static int config_output(AVFilterLink *outlink)
s->fft_input = av_calloc(FFALIGN(s->fft_len + 64, 256), sizeof(*s->fft_input));
s->fft_result = av_calloc(FFALIGN(s->fft_len + 64, 256), sizeof(*s->fft_result));
s->cqt_result = av_malloc_array(s->cqt_len, sizeof(*s->cqt_result));
- if (!s->fft_ctx || !s->fft_data || !s->fft_result || !s->cqt_result)
+ if (!s->fft_ctx || !s->fft_data || !s->fft_input || !s->fft_result || !s->cqt_result)
return AVERROR(ENOMEM);
s->remaining_fill_max = s->fft_len / 2;
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-08-07 2:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807023423.38303-1-jiashengjiangcool@gmail.com \
--to=jiashengjiangcool@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git