Re: [FFmpeg-devel] [PATCH v3] examples: Add check and replace av_free() to avoid potential memory errors

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1096 bytes --]

On Wed, Aug 06, 2025 at 04:56:42PM +0200, Nicolas George wrote:
> Jiasheng Jiang (HE12025-08-06):
> > Add check for the return value of av_packet_alloc() to avoid potential NULL pointer dereference.
> > Moreover, replace redundant av_free() with fprintf().
> > 
> > Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically")
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> > ---
> > Changelog:
> > 
> > v2 -> v3:
> > 
> > 1. Remove wrong Fixes tag.
> > 
> > v1 -> v2:
> > 
> > 1. Remove unnecessary goto.
> > 2. Add fprintf() for error message.
> > ---
> >  doc/examples/decode_audio.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Still looks good to me, of course, thanks.
> 
> I do not maintain the docs.

will apply

thx for review


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".