[FFmpeg-devel] [PATCH] libavfilter/af_firequalizer: Add check for av_malloc_array()

[FFmpeg-devel] [PATCH] libavfilter/af_firequalizer: Add check for av_malloc_array()

[Jiasheng Jiang]

Add check for the return value of av_malloc_array() to avoid potential NULL pointer dereference.

Fixes: d3be186ed1 ("avfilter/firequalizer: add dumpfile and dumpscale option")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 libavfilter/af_firequalizer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavfilter/af_firequalizer.c b/libavfilter/af_firequalizer.c
index 38663200eb..f14983b431 100644
--- a/libavfilter/af_firequalizer.c
+++ b/libavfilter/af_firequalizer.c
@@ -808,6 +808,8 @@ static int config_input(AVFilterLink *inlink)
         if ((ret = av_tx_init(&s->analysis_rdft, &s->analysis_rdft_fn, AV_TX_FLOAT_RDFT, 0, 1 << rdft_bits, &scale, 0)) < 0)
             return ret;
         s->dump_buf = av_malloc_array(s->analysis_rdft_len + 2, sizeof(*s->dump_buf));
+        if (!s->dump_buf)
+            return AVERROR(ENOMEM);
     }
 
     s->analysis_buf = av_malloc_array((s->analysis_rdft_len + 2), sizeof(*s->analysis_buf));
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavfilter/af_firequalizer: Add check for av_malloc_array()

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 626 bytes --]

On Wed, Aug 06, 2025 at 04:39:47PM +0000, Jiasheng Jiang wrote:
> Add check for the return value of av_malloc_array() to avoid potential NULL pointer dereference.
> 
> Fixes: d3be186ed1 ("avfilter/firequalizer: add dumpfile and dumpscale option")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
>  libavfilter/af_firequalizer.c | 2 ++
>  1 file changed, 2 insertions(+)

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".