From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C61C04C988 for ; Thu, 7 Aug 2025 00:22:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2730A68CC6F; Thu, 7 Aug 2025 03:22:52 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7E29B68C850 for ; Thu, 7 Aug 2025 03:22:45 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id D81BF1F68F for ; Thu, 7 Aug 2025 00:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754526165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hIsVXF0ANZe3xKME7xwmRGSJluB2NDbQdss98LRCQlE=; b=AxtNbnDSr/Pb0J0E/iVOvRjJKEnxc2IRLZOqCWvxEhrtlkcerH9hvjmz1lShRXgbB1rLq5 cQ2AB++CBdYEHHn9H+P/Atx842paZJu6nOrBoLkgg6xu0rQe0F2VT8iXVua8toYtiy3O6i iZztpGIW01z2wenvfa0o9ddIaTppCrmTw/neSl3rEiYbMroHlNRqOTS79i5Jpjb8ooVRk7 xgPzA2VkhtsART8O6y74B2ID2xkRB6WLp8VuSzYZHjHUp5Ga+ZI/3H55JdpeWmDWnGuAh1 wpCebStRgcktzwdo0b9QA9Gbp3NM2VAdV+yYrjwT3CfEJGHVFHONp8F8euIJpA== Date: Thu, 7 Aug 2025 02:22:43 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250807002243.GA29660@pb2> References: <20250805193115.14842-1-jiashengjiangcool@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250805193115.14842-1-jiashengjiangcool@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduudelgeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolbox_vp9: Move av_malloc() to avoid memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6806531865421417003==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6806531865421417003== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/M49KTkKIiayttkv" Content-Disposition: inline --/M49KTkKIiayttkv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 05, 2025 at 07:31:15PM +0000, Jiasheng Jiang wrote: > Move av_malloc() after the check for subsampling to avoid memory leak if = subsampling < 0 and av_malloc() succeeds. >=20 > Fixes: a41a2efc85 ("lavc/videotoolbox: add VP9 hardware acceleration") > Signed-off-by: Jiasheng Jiang > --- > libavcodec/videotoolbox_vp9.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better. --/M49KTkKIiayttkv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaJPx0wAKCRBhHseHBAsP qyd8AJ9yJnjiID5obiH3DjsjYtUrGedYeQCdFLuhwZuvsC2ncKMStfWXZ/lPNh4= =yfon -----END PGP SIGNATURE----- --/M49KTkKIiayttkv-- --===============6806531865421417003== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6806531865421417003==--