From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 42D604C8FA for ; Wed, 6 Aug 2025 14:54:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B217C68CB22; Wed, 6 Aug 2025 17:54:33 +0300 (EEST) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 105B968C30B for ; Wed, 6 Aug 2025 17:54:27 +0300 (EEST) Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3e3ef0024acso4987535ab.0 for ; Wed, 06 Aug 2025 07:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754492065; x=1755096865; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=o71p220D7hPR8fX0ah9K6HVPoM+Jsk9jr03Ffv4QsUQ=; b=SCVDvQkd5XDjiUTuPOUQajfE5TBbWp/jsskCXqsc/nMZYqe6C637MCI9vT+z1e6bgl T2gEfndhMnzNfKaH02+VcGdImEOKZ3W4/0HowL/6U0d/f4fFwU0nKggu/LVhE83ueLKk ZwjchzOVjHKXfTcoGvzdzZ6j/D55VszzLQGYqAGiCOnZZax3BRI2/K5xr2VLViPZahnM JtYf8qZ2TK6s8lj0DL6KOTeoCgZ1SWE4XhPFLlQx7x1kQhVe3dLgTe+qm9wylrKRsPL/ 4W7cM1Pfeh4K14KY91D+AEsQUIE3Fa5z2AeB/5JJLzz552W8SZIMWeYgG8nRnU1Qjj9g /otA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754492065; x=1755096865; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o71p220D7hPR8fX0ah9K6HVPoM+Jsk9jr03Ffv4QsUQ=; b=ulosy9RxJdw9W5I28Au3kyg0ZRtfRLALIYMHQKfJkwzJz0ptT4TOZftaBolWQJAhAf x1AiH/jpaYS6YXhGIU9lk+QhwJENKsdbegGSYGKKgPpilMexFZc0gercgmLHfoYOxcKS nd5ZJ/un6M8vChLKJIjG69bEBJ49cbm2cAYbwgaUZkTfTvkFH8lL/gNxMwBJLgVP0rJh fTDxfWkuRPreVfZZpOvZyFqP0qrcSRcTXTPMbpmcL813O9aBe8L1hWhRHaxhw/B8PyJ3 r/kq6zZehTnyaLffhb7BQ8mizm8yAQXtkNmUtOXvocIta1UQV+XW4joNtPV1xAsMT+sV rvmA== X-Gm-Message-State: AOJu0Yzl9YfyoCy7NHTujboc6tbOhndj9eOWV6BvwVRwB/2BvRpw4YjL DHg2qjiDKGUcPzHG15tlwxIxCtGVo2ot/wqKJR2oXvSA16gVmL/zr71WjlRSIw== X-Gm-Gg: ASbGncuHN4rmZ7NwfVl/1QxGU+WeQ9RA84wFVRk3Xzrw1MRP75x0uPhPQLzpTvreI1m hgcvUQsk7U3r1HKPFq0Gs2rlQerTJi/l7oyKS1PkbwRmFEkIo6PzgYPERpmjd0hIQ/NDPsocVP4 ROPcdVVMZWDXneEhT9qR4EVgKPxXf5SmbBHXsKLcCGnM+D/gRGzADNMMdnLWynVf4OzShbqDVFU j1Q8RPaeNOJEJaD6QSP3jBxHBzxNli3AwlMQVnR6SwI4fkerUceEYzUzKso44p1oDM1BaaCIRwp d2JrHp0KpCXdjZ6pqKQvG22Omy+uMKcjMpSDout4vi3fmFYn40fz0+5hKH3gf7iUsvwFGrO3v00 IHr7y5I2Yu4cME9AsAd6K7ydWp1lEFMbn9vY/Cm8hn0Xt X-Google-Smtp-Source: AGHT+IHXaHdApuLnEKNArgTUJDNj9oT9Pjfk0R0thTszVTItz8MKOmXrEHbc9vS54IabV64/hz2AeQ== X-Received: by 2002:a92:c5cf:0:b0:3e3:b3d0:26cf with SMTP id e9e14a558f8ab-3e51add3ee7mr39309585ab.10.1754492065002; Wed, 06 Aug 2025 07:54:25 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50a55da3351sm4954924173.87.2025.08.06.07.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Aug 2025 07:54:24 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Wed, 6 Aug 2025 14:54:22 +0000 Message-Id: <20250806145422.31198-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3] examples: Add check and replace av_free() to avoid potential memory errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add check for the return value of av_packet_alloc() to avoid potential NULL pointer dereference. Moreover, replace redundant av_free() with fprintf(). Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically") Signed-off-by: Jiasheng Jiang --- Changelog: v2 -> v3: 1. Remove wrong Fixes tag. v1 -> v2: 1. Remove unnecessary goto. 2. Add fprintf() for error message. --- doc/examples/decode_audio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index bcb3d87a69..26ce07a552 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -128,6 +128,10 @@ int main(int argc, char **argv) outfilename = argv[2]; pkt = av_packet_alloc(); + if (!pkt) { + fprintf(stderr, "Could not allocate AVPacket\n"); + exit(1); /* or proper cleanup and returning */ + } /* find the MPEG audio decoder */ codec = avcodec_find_decoder(AV_CODEC_ID_MP2); @@ -161,7 +165,7 @@ int main(int argc, char **argv) } outfile = fopen(outfilename, "wb"); if (!outfile) { - av_free(c); + fprintf(stderr, "Could not open %s\n", outfilename); exit(1); } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".