From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F16474C8E6 for ; Wed, 6 Aug 2025 14:49:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7490968BA24; Wed, 6 Aug 2025 17:49:24 +0300 (EEST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8B922687A98 for ; Wed, 6 Aug 2025 17:49:18 +0300 (EEST) Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-88180b57db7so101042639f.0 for ; Wed, 06 Aug 2025 07:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754491756; x=1755096556; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nNNVEaIsKQW7U6mfGeOVpzKVKS32C4ISkO3nBcsCFPc=; b=B3ybdNmct7+D5WwxKBulvsc8CMdUGO/9LCf80WWio9yPJNbaHETfTMIoXdjC5orf+g 6fa5FeDEfguuyGb+z/8KvDG6g8nW3r5HufjBhmGa8ULaXNU0njG5aGkEzehvTU8uIdVh BNxGI+gOhBnHd7jJNrDRN4SKoX3wVqYqZmQANZ79tF3ZN41Ny5CqgiOfJRzzWif7dGT+ ZLNChaYoeXvjZIUOxOmyW4zHb0pNbk7sYqVgjniS49PCzptcReD26w0uJsF/MIJW9tvC UCGyrHhxYd9CrZcODNtibcjfl2maVWaOtR90nlxjRhog+y1xum8G0OPeupBnKsQiwfGW fPAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754491756; x=1755096556; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nNNVEaIsKQW7U6mfGeOVpzKVKS32C4ISkO3nBcsCFPc=; b=FmJGAcZNV6i5azhdgcGHg5qi4kVo6JQhjkovKfsJfIcWe3Kd63VBUQcomBSnXyReID yx42faZimOj2gd8yHCgNqj959DMhtVBAJCOPX0XRNZdf9tIeUCFlQRJUMCPS1If9sfyV 2z1/SfRQkdOGKH7AfUb6C1QmfZIlZbKDBKyOEVJVY+mI1GxPmz9rJzxaAMfrxxMoCgYe pbT5P/5ERerDM+IihfpLp4jWTeBll/iyNWFA5H/7uhKWQRZtVx0b2U8cyuV6hLyniddx QgUlk6raeV/GL5gj6HK7DyHtvnC6PpEtWp+w2e0/WNxn9kqWkSzneQIBGaqCndHI4gLi aHaQ== X-Gm-Message-State: AOJu0Yzscbix/8btD0ebdqyWoe2W19nDl4JezrNFh8ApaBNkXRDgR9pD BPWnSD6wgk9OaNYFKReCNYiRUVhwbJl3p9EnYzWD3NwGXJSl7iW23DfHSV1Ekw== X-Gm-Gg: ASbGnct3NG5iIjpV5Ntlgh/NEFuuLgU7PX1eyCMZzmMGCFn71pPZoAqsdq/4/N5JJxX 2hYLf9gJ8lM8XsCiBmTUpe00MHx90g/UjNEXJkjvJwSTri0iB63CvQkbKymJIXJ2Dnpp06Q3Is5 ZoR8ApO+7+fZAr1NNS+V6ZKT4t3+uZQurhgUA+X5ScWepFubHYL8+d/z6HanDdDEslisbm09j98 HTJImylDVY9Kn6v41n5BEpzFb6VtoH1tGdRw1FuaCS6JvGC0/qA/TtQZEw0HfAvhB2vFjNWxTxe InKygfVuxoa1Ek/UqvtODV9nREgUG4EBNX/ipJYSZ15b0xFQiXLgPx8husuv47uSRkh1ICxg5LL GPcjVQiK5jIW9ibnpik1Njgj4xfHgkaaRX35V6c45F0VhxXbg/qm8aSw= X-Google-Smtp-Source: AGHT+IHqv9zEIUvRAOG6GueSyFD1C6lo4zYGzCPPvFn8LOT+C4c9BJ3/eV1jJzstofyTwrUNHa2BhA== X-Received: by 2002:a05:6e02:12ce:b0:3e3:ccdb:6ccc with SMTP id e9e14a558f8ab-3e51b894105mr49223475ab.3.1754491755886; Wed, 06 Aug 2025 07:49:15 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e50f775996sm20384455ab.42.2025.08.06.07.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Aug 2025 07:49:15 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Wed, 6 Aug 2025 14:49:12 +0000 Message-Id: <20250806144912.31065-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] examples: Add check and replace av_free() to avoid potential memory errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add check for the return value of av_packet_alloc() to avoid potential NULL pointer dereference. Moreover, replace redundant av_free() with fprintf(). Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically") Fixes: f5df897c4b ("examples/avcodec: split audio decoding into a separate example") Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. Remove unnecessary goto. 2. Add fprintf() for error message. --- doc/examples/decode_audio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index bcb3d87a69..26ce07a552 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -128,6 +128,10 @@ int main(int argc, char **argv) outfilename = argv[2]; pkt = av_packet_alloc(); + if (!pkt) { + fprintf(stderr, "Could not allocate AVPacket\n"); + exit(1); /* or proper cleanup and returning */ + } /* find the MPEG audio decoder */ codec = avcodec_find_decoder(AV_CODEC_ID_MP2); @@ -161,7 +165,7 @@ int main(int argc, char **argv) } outfile = fopen(outfilename, "wb"); if (!outfile) { - av_free(c); + fprintf(stderr, "Could not open %s\n", outfilename); exit(1); } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".