From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EE6524C812 for ; Tue, 5 Aug 2025 19:31:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 394ED68C6E9; Tue, 5 Aug 2025 22:31:27 +0300 (EEST) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6EFE3687C16 for ; Tue, 5 Aug 2025 22:31:20 +0300 (EEST) Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-433f787057eso1849507b6e.2 for ; Tue, 05 Aug 2025 12:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754422278; x=1755027078; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WbeD9eWo0LNKUy0FWjePA4YZ2w2WGJg3hfgIMEblC9M=; b=cROEzsxsE/s54JxgB4S/af1xhhwVfFUQcCvd9zV6dWKb9MRisH6S82z/8rnvGtjFFG y4uLNyf3UkOHAlKQQ0BBJWAXxz2gCGogpKy4VNlMKooBWgn6osZB7FIkKqblp+c4td2R Eb3jP8V2hJvFfkuLgzU2jPHBzFLrRgSfJ2nyijAE6wWSRdMPUTvkhEb99mD68cCft9aS F8hU7trHdH6gjg2uv5OLz+kjsMVBXQnRhcAQZI2JVrKi4ugNfuf8+Pbc3bOd1VjNB4kv ZAbBpHW0J5SB0gcfvq5wL81l3mEAyFupOsCHLoyq+vtfqqhzkjYQrAB1kBpD14dDnxvk n8pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754422278; x=1755027078; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WbeD9eWo0LNKUy0FWjePA4YZ2w2WGJg3hfgIMEblC9M=; b=fghTqWVfujI3tArpOPtWgTDrpagRxDwvMA1Utphx17dM+kA2/AU5B08F/HjZHDE7A7 Lfbfho5wdscVcJg01S0CivCAXQDBWQQ2EAffqYfKSTERQshYGrAX3hODdbTo6acePfiH pHXuHFX/zbg9RVzsyqkjZp4lLMoachsOvGMzbWYX2Mj0vz0ePX6sVvHKH484oUz651w+ Dh3RlJs0zju1McAs+6yVrd+GmEao1rvTKnBaYADx/CMqnpA8w1xT8PCLb57sLDBe/rRr FlUmh7cssUU6Re1vUz3faNedas0Yi+4IQrxa4+pU2xWkT2La+ajSEKWubNxdNlDx1/Sl iamQ== X-Gm-Message-State: AOJu0YwQwnHgiEOcQ3/xQVNkeYnxyb2Uu0+lCHhCJE3k0cbd4RShmZeE bhAaET1j1Fta1hLEoWHqYdW3BWWyXT3w7Dy3KcVyYnVGTaQQObEWkWjXlag/uA== X-Gm-Gg: ASbGncsR4YbfPzaNCFhx5r+0MegZu8p9Kz2/x4s+4e+s/lbb4iGz/cvuEWVeIRGyXYq jeo99B+74VQH0J+kzaMBfAb+FKkPlkSKRFk8NYlrtg4VL7ZzzythvmRO27tAcmb0LNtJl4NCTS8 mZUIH6HIQ79YnXePAXH4/g0WhFSnuAMEAZlP+vZA9iN9nb3iuN3iKlCUSnTeAcTXKh8OniVFe0S 5JjujBel4v42co5fmWnQ/o0dvfbMYNfH6VGx9dN3tUcHEqM5uS0z4iSiWGsLw0+1cIIQ6XWsY/K s4GOdUey/s8h9q9XEPb5Qhx32p1IK0g2IyrkYmjge039lUgRak0AF4P8pf2gkc762TPxvgtaSXH eOy/odutmajfCHEK75KirhD+6gHyOunpAnp7MB7DrT0Gl X-Google-Smtp-Source: AGHT+IGIg+o0haGKh73Kiu07CHdd9JgAop7qC5fNA2YGIBFD9gtnSv2a0thIrB4985EDSgvGzbpX6w== X-Received: by 2002:a05:6808:1b29:b0:434:d23:b7bd with SMTP id 5614622812f47-43579f2288cmr353696b6e.3.1754422277981; Tue, 05 Aug 2025 12:31:17 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50a64d441e8sm3803683173.15.2025.08.05.12.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 12:31:17 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Tue, 5 Aug 2025 19:31:15 +0000 Message-Id: <20250805193115.14842-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavcodec/videotoolbox_vp9: Move av_malloc() to avoid memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Move av_malloc() after the check for subsampling to avoid memory leak if subsampling < 0 and av_malloc() succeeds. Fixes: a41a2efc85 ("lavc/videotoolbox: add VP9 hardware acceleration") Signed-off-by: Jiasheng Jiang --- libavcodec/videotoolbox_vp9.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/videotoolbox_vp9.c b/libavcodec/videotoolbox_vp9.c index de7fc0c935..f2cb34fca4 100644 --- a/libavcodec/videotoolbox_vp9.c +++ b/libavcodec/videotoolbox_vp9.c @@ -71,12 +71,12 @@ CFDataRef ff_videotoolbox_vpcc_extradata_create(AVCodecContext *avctx) uint8_t *vt_extradata; int subsampling = get_vpx_chroma_subsampling(avctx->sw_pix_fmt, avctx->chroma_sample_location); - vt_extradata_size = 1 + 3 + 6 + 2; - vt_extradata = av_malloc(vt_extradata_size); - if (subsampling < 0) return NULL; + vt_extradata_size = 1 + 3 + 6 + 2; + vt_extradata = av_malloc(vt_extradata_size); + if (!vt_extradata) return NULL; -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".