From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C3C3E4C808 for ; Tue, 5 Aug 2025 18:56:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7AC0868C41B; Tue, 5 Aug 2025 21:56:21 +0300 (EEST) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id AE5F4687BE7 for ; Tue, 5 Aug 2025 21:56:14 +0300 (EEST) Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-88105a23088so159319739f.3 for ; Tue, 05 Aug 2025 11:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754420172; x=1755024972; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ttEKe5SG9SIRl2NOnx2/FDyvk1qZc6OKxeVt9yiBcao=; b=CpBZ7/ksjtroutXECrLn52yVlh1x26/6Nab9MJXoR46hng+1S6npn5oqVhQPfmomdu IjL3YQ1b+C2SA70pr7pfaa/1nrrGMGrlIW1DJpwKQB8VM2vsRXmLxwJ5IUvyZkr7D854 8z6jPQ/hCQCIM+GUTEHmKh2gXv6ulvaZsT58grIJgxKvVEgbOapdIoBEmi3B5V3DKdQ7 ispSBt9ilzrYTEIWOmJ5eZlUqg9fJiTaXuBJbv26Pw9Tj3iDQHxtXUXE2UxQ15DgDorP AeiRUJvAJIcisGfhn0/Fs2GR2Q0LUWqBT9EH3Zn/Nw+IGrf3mxaMl1/swxlknDM3Id35 G30w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754420172; x=1755024972; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ttEKe5SG9SIRl2NOnx2/FDyvk1qZc6OKxeVt9yiBcao=; b=ZmEGlCyznDC4pP6Gq99AeWsiPj21Mehfwo+Se81jlQtENF06AjwwWOt0tuKe2v8BDi Fn77lGaU2x6+d6TdRqgolT+inuUW9U73qcb9DHEuAIjskbzYxjD8MG1ESnDyRR8vZ+tx ZNypQ2KK22EtABsQmx15EDm4VbJD5v3rMtwpnxaDdwl5ZVbsnnUriGFzBv/xMpDmlg7q fn4h5hJh8prVV7pY/L9iinXxhxSAFOHB/GTZ1mqMpWf0bdyK3vyEGz7fChA2RWvDd3lD OpkjxYUQ6/gpM9O4mXnNiCXDW0vgoiCBF/XNX0gRxizzOaPjVkPoXsHtU0n6e5xwTvKJ h/8Q== X-Gm-Message-State: AOJu0YxMXGPiW9E12zlzc3wF8g4lPuNuHpdyBJK/B+hhMni8ka9x5LDr tW1GVNWCQnPG8FbjF+ydUlUZGPJJq2lISfH1YbVJdKsPkechS0rX2qe3H1ICTQ== X-Gm-Gg: ASbGncvlqq+pkvH9kfR+iDiXdXizlOFLaDYA3SL8EfB/WVfF1LBxDsxcWVWsb9ykWI6 QrK8o4UNVstZCYsckuvfd0ssRlWdSHTpGEeE0CVtxgD8iuXEZh9DDkJpvPpIZeOUfWq2JxDQSLG KTem46Ynoy6p7FC2eatRXTI3KF5OlHTeN0tx933+3uOA4jSUayxcKELK8W413gQujBkBqtY5j3c zADym9fSDbKh1K5QYEexTs+MPpjzRrkE2GdMetp8uALm1+TOK9c6Gwa5NjLXbWtQzTR/MktS+re GyexQQSPMDSwzBRv/3cuQ/pq9iGgRBQmfBWhEUCYhBJmlRrkR+QMGnG/XbxBS0pjALurVpwR4Km 9qHPU0HERV2Vm7JLjH8ntlQjPxo/+Yx5OVXufBzeKZO7yCmaBLtYDids= X-Google-Smtp-Source: AGHT+IGwa4OjvlSFfNXFRKyuamfeio7MWDA4ROKMWJkJgADcvF1tkxFWQg6xrommk2yqybAJM5U3hQ== X-Received: by 2002:a05:6e02:360b:b0:3e2:c62c:5531 with SMTP id e9e14a558f8ab-3e41618bf16mr261092385ab.20.1754420172088; Tue, 05 Aug 2025 11:56:12 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e50f058d5bsm12981945ab.40.2025.08.05.11.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 11:56:11 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Tue, 5 Aug 2025 18:56:09 +0000 Message-Id: <20250805185609.11596-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] examples: Replace with proper error handling to avoid potential memory errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add check for the return valud of av_packet_alloc() to avoid potential NULL pointer dereference. Moreover, replace with proper error handling to avoid potential memory leak. Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically") Fixes: f5df897c4b ("examples/avcodec: split audio decoding into a separate example") Signed-off-by: Jiasheng Jiang --- doc/examples/decode_audio.c | 39 +++++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index bcb3d87a69..7d9093c0e9 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -128,41 +128,48 @@ int main(int argc, char **argv) outfilename = argv[2]; pkt = av_packet_alloc(); + if (!pkt) + exit(1); /* find the MPEG audio decoder */ codec = avcodec_find_decoder(AV_CODEC_ID_MP2); if (!codec) { fprintf(stderr, "Codec not found\n"); - exit(1); + ret = -1; + goto free_pkt; } parser = av_parser_init(codec->id); if (!parser) { fprintf(stderr, "Parser not found\n"); - exit(1); + ret = -1; + goto free_pkt; } c = avcodec_alloc_context3(codec); if (!c) { fprintf(stderr, "Could not allocate audio codec context\n"); - exit(1); + ret = -1; + goto close_parser; } /* open it */ if (avcodec_open2(c, codec, NULL) < 0) { fprintf(stderr, "Could not open codec\n"); - exit(1); + ret = -1; + goto free_context; } f = fopen(filename, "rb"); if (!f) { fprintf(stderr, "Could not open %s\n", filename); - exit(1); + ret = -1; + goto free_context; } outfile = fopen(outfilename, "wb"); if (!outfile) { - av_free(c); - exit(1); + ret = -1; + goto fclose_f; } /* decode until eof */ @@ -173,7 +180,8 @@ int main(int argc, char **argv) if (!decoded_frame) { if (!(decoded_frame = av_frame_alloc())) { fprintf(stderr, "Could not allocate audio frame\n"); - exit(1); + ret = -1; + goto fclose_outfile; } } @@ -182,7 +190,7 @@ int main(int argc, char **argv) AV_NOPTS_VALUE, AV_NOPTS_VALUE, 0); if (ret < 0) { fprintf(stderr, "Error while parsing\n"); - exit(1); + goto end; } data += ret; data_size -= ret; @@ -225,13 +233,20 @@ int main(int argc, char **argv) fmt, n_channels, c->sample_rate, outfilename); end: + av_frame_free(&decoded_frame); +fclose_outfile: fclose(outfile); +fclose_f: fclose(f); - +free_context: avcodec_free_context(&c); +close_parser: av_parser_close(parser); - av_frame_free(&decoded_frame); +free_pkt: av_packet_free(&pkt); + if (ret < 0) + exit(1); + return 0; -} +} \ No newline at end of file -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".