Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marvin Scholz <epirat07@gmail.com>, Lynne <dev@lynne.ee>,
	Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.
Date: Mon, 4 Aug 2025 10:21:33 +0200
Message-ID: <20250804082133.GS29660@pb2> (raw)
In-Reply-To: <20250804001103.GR29660@pb2>


[-- Attachment #1.1: Type: text/plain, Size: 1434 bytes --]

Hi Romain

On Mon, Aug 04, 2025 at 02:11:03AM +0200, Michael Niedermayer wrote:
> Hi Romain
> 
> On Sun, Aug 03, 2025 at 05:50:17PM -0500, Romain Beauxis wrote:
> > Le dim. 3 août 2025 à 16:36, Michael Niedermayer
> > <michael@niedermayer.cc> a écrit :
> [...]
> > > > Do you have any advice on how to look for a reviewer for this path?
> > >
> > > social media, like twitter
> > >
> > > also if it has a positive vibe then we can retweet
> > 
> > Respectfully, this does not make sense to me.
> 
> i dont have time ATM, and it seems the others also are overloaded
> 
> -> so the goal is to attract more reviewing manpower
> 
> but surely eventually someone will have time and look at it
> also this is not the most trivial patchset

I ve reviewed your patch on https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026 now

you ignored review comments made previously

The patch also contained a trivial mistake:
(maybe review your own code if you have time and reviewers are all busy)
(also as said previously (IIRC) if reviewers are all busy, help review other peoples
 patches)
        priv->comment_size = 0;
        av_freep(&priv->setup);
        priv->comment_size = 0;

Also its summer vacation time and everyone is busy

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Some Animals are More Equal Than Others. - George Orwell's book Animal Farm

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2025-08-04  8:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 16:58 Romain Beauxis
2025-06-10 18:04 ` Romain Beauxis
2025-06-12 11:35   ` Michael Niedermayer
2025-06-14 10:39     ` Romain Beauxis
2025-06-14 22:57 ` Michael Niedermayer
2025-06-21  8:45   ` Romain Beauxis
2025-06-21 21:59     ` Michael Niedermayer
2025-07-23 19:06       ` Romain Beauxis
2025-07-28  0:22         ` Michael Niedermayer
2025-07-28 21:12           ` Romain Beauxis
2025-08-03 21:36             ` Michael Niedermayer
2025-08-03 22:50               ` Romain Beauxis
2025-08-04  0:11                 ` Michael Niedermayer
2025-08-04  0:19                   ` Kieran Kunhya via ffmpeg-devel
2025-08-04 10:53                     ` Nicolas George
2025-08-04  8:21                   ` Michael Niedermayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250804082133.GS29660@pb2 \
    --to=michael@niedermayer.cc \
    --cc=andreas.rheinhardt@outlook.com \
    --cc=dev@lynne.ee \
    --cc=epirat07@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git