[FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_packet_free() to avoid memory leak

[FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_packet_free() to avoid memory leak

[Jiasheng Jiang]

Add av_packet_free() to free avpkt_clone and avpkt in the error paths to avoid potential memory leak.

Fixes: da3c69a5a9 ("Added test for libavcodec/avpacket.c")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 libavcodec/tests/avpacket.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/tests/avpacket.c b/libavcodec/tests/avpacket.c
index 1d4833839a..de76591f17 100644
--- a/libavcodec/tests/avpacket.c
+++ b/libavcodec/tests/avpacket.c
@@ -101,11 +101,14 @@ int main(void)
 
     if(!avpkt_clone) {
         av_log(NULL, AV_LOG_ERROR,"av_packet_clone failed to clone AVPacket\n");
+        av_packet_free(&avpkt);
         return 1;
     }
     /*test av_grow_packet*/
     if(av_grow_packet(avpkt_clone, 20) < 0){
         av_log(NULL, AV_LOG_ERROR, "av_grow_packet failed\n");
+        av_packet_free(&avpkt_clone);
+        av_packet_free(&avpkt);
         return 1;
     }
     if(av_grow_packet(avpkt_clone, INT_MAX) == 0){
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_packet_free() to avoid memory leak

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 593 bytes --]

On Sun, Aug 03, 2025 at 08:09:38PM +0000, Jiasheng Jiang wrote:
> Add av_packet_free() to free avpkt_clone and avpkt in the error paths to avoid potential memory leak.
> 
> Fixes: da3c69a5a9 ("Added test for libavcodec/avpacket.c")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
>  libavcodec/tests/avpacket.c | 3 +++
>  1 file changed, 3 insertions(+)

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".