[FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_free() to avoid memory leak

[FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_free() to avoid memory leak

[Jiasheng Jiang]

Add av_free() to free extra_data if av_packet_add_side_data() fails.

Fixes: da3c69a5a9 ("Added test for libavcodec/avpacket.c")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 libavcodec/tests/avpacket.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavcodec/tests/avpacket.c b/libavcodec/tests/avpacket.c
index 1d4833839a..b81b0df1c0 100644
--- a/libavcodec/tests/avpacket.c
+++ b/libavcodec/tests/avpacket.c
@@ -51,6 +51,7 @@ static int setup_side_data_entry(AVPacket* avpkt)
     ret = av_packet_add_side_data(avpkt, AV_PKT_DATA_NEW_EXTRADATA,
                                         extra_data, bytes);
     if(ret < 0){
+        av_free(extra_data);
         fprintf(stderr,
                 "Error occurred in av_packet_add_side_data: %s\n",
                 av_err2str(ret));
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_free() to avoid memory leak

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 578 bytes --]

On Sun, Aug 03, 2025 at 07:14:38PM +0000, Jiasheng Jiang wrote:
> Add av_free() to free extra_data if av_packet_add_side_data() fails.
> 
> Fixes: da3c69a5a9 ("Added test for libavcodec/avpacket.c")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
>  libavcodec/tests/avpacket.c | 1 +
>  1 file changed, 1 insertion(+)
> 

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".