From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EE3044C588 for ; Sun, 3 Aug 2025 23:13:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0ECE068C3C2; Mon, 4 Aug 2025 02:13:03 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3635468BFB6 for ; Mon, 4 Aug 2025 02:12:56 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4AC924327F for ; Sun, 3 Aug 2025 23:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754262775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JsmLXrqJm8iOXI48nM1/Y7/21hYQwRgc8SNbDVPA8JM=; b=alBucTHMyc0O5z8FaBdUG5MQdbMu2Eu5bDxu0LJ0Fd/4JJ1hhXhagy98B+YRUilnSpMoGw PM2dCcXdx52cyY59YGlvufu72n7rvhdwcCQ8U7YVPzVdz6VFTk3tlwO4wQAuOc9Tx65cya XG9k9tVwpN59NkGRP3AhbwtMd7wbFRYV5LotT/QdYBXKeaPgbw886lyeuCfppQm4xdeDQV 0qKi7KSu8mYXbKOJjvTOAPfL/xf1K5DLISgvGgl0NrUS0ZJk6W81Im+I8I0n/96XdgX6sJ tasAACdHl8Cg0EZZC3lElYk+LrKEsbsfmqvI/jcUygAVcDWoNLD//gFYm9qlAQ== Date: Mon, 4 Aug 2025 01:12:54 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250803231254.GM29660@pb2> References: <20250731141914.GS29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduuddtjeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] libopenmpt: fix seeking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6983379722259043739==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6983379722259043739== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ogx8fMFAKvLNkedm" Content-Disposition: inline --ogx8fMFAKvLNkedm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Kimapr On Fri, Aug 01, 2025 at 11:04:44AM +0500, kimapr via ffmpeg-devel wrote: > revised the patch, hopefully it's better now. i also fixed > another weirdness that i didn't fix in the original patch >=20 > On 2025/07/31 19:19, Michael Niedermayer wrote: >=20 > > while your email contains quite some details, the commit message of > > just "libopenmpt: fix seeking" is too terse >=20 > added some details! >=20 > > is there any possibility of a "unknown" "position" ? > > if not its fine otherwise a check may be needed to handle that >=20 > no idea. openmpt docs don't mention the possibility, and > besides like returning a NaN there isn't really much the API > can do to indicate such a condition >=20 > > is it possible that this exceeds the int64_t range ? > > if so these out of range values should probably be replaced by AV_NOPTS= _VALUE >=20 > seems unlikely! i added a check anyway though (should also catch the > unknown position if it is indicated by a NaN). rather than replacing > the value with AV_NOPTS_VALUE i just don't set it. Is that good? > libopenmpt.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > d56bcab23e1efd2f1b928bc742cdb13ca1ead6c7 0001-libopenmpt-fix-seeking-wei= rdness.patch > From d6418b665cc80a1680afee8259a242a42c0ed2ad Mon Sep 17 00:00:00 2001 > From: Kimapr > Date: Mon, 28 Jul 2025 06:32:27 +0500 > Subject: [PATCH] libopenmpt: fix seeking weirdness >=20 > - proper pts for packets. leaving it blank leaves it up for guessing, > but the guess doesn't take seeking into account, causing weirdness. >=20 > - clamp to 0 when seeking to negative ts. libopenmpt docs are unclear on > this but not doing this causes an immediate EOF when seeking backwards > to the beginning in mpv. >=20 > - only set song duration and packet pts when they are non-negative and > in int64 range. NaNs count as out of range. this isn't a fix for any > specific issue but might be helpful still, and shouldn't break > anything. can you split this in 3 patches, it sounds like these are 3 distinct changes thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato --ogx8fMFAKvLNkedm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaI/s9gAKCRBhHseHBAsP qxgKAJ9fVT3azDr0qhJc+YA0wMDnSWDOvQCfRhIFXepqi4TlZWwRSN6elBhMYWw= =ZE78 -----END PGP SIGNATURE----- --ogx8fMFAKvLNkedm-- --===============6983379722259043739== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6983379722259043739==--