Re: [FFmpeg-devel] [PATCH] libopenmpt: fix seeking

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2356 bytes --]

Hi Kimapr

On Fri, Aug 01, 2025 at 11:04:44AM +0500, kimapr via ffmpeg-devel wrote:
> revised the patch, hopefully it's better now. i also fixed
> another weirdness that i didn't fix in the original patch
> 
> On 2025/07/31 19:19, Michael Niedermayer wrote:
> 
> > while your email contains quite some details, the commit message of
> > just "libopenmpt: fix seeking" is too terse
> 
> added some details!
> 
> > is there any possibility of a "unknown" "position" ?
> > if not its fine otherwise a check may be needed to handle that
> 
> no idea. openmpt docs don't mention the possibility, and
> besides like returning a NaN there isn't really much the API
> can do to indicate such a condition
> 
> > is it possible that this exceeds the int64_t range ?
> > if so these out of range values should probably be replaced by AV_NOPTS_VALUE
> 
> seems unlikely! i added a check anyway though (should also catch the
> unknown position if it is indicated by a NaN). rather than replacing
> the value with AV_NOPTS_VALUE i just don't set it. Is that good?

>  libopenmpt.c |   12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> d56bcab23e1efd2f1b928bc742cdb13ca1ead6c7  0001-libopenmpt-fix-seeking-weirdness.patch
> From d6418b665cc80a1680afee8259a242a42c0ed2ad Mon Sep 17 00:00:00 2001
> From: Kimapr <kimapr.fr@gmail.com>
> Date: Mon, 28 Jul 2025 06:32:27 +0500
> Subject: [PATCH] libopenmpt: fix seeking weirdness
> 
> - proper pts for packets. leaving it blank leaves it up for guessing,
>   but the guess doesn't take seeking into account, causing weirdness.
> 
> - clamp to 0 when seeking to negative ts. libopenmpt docs are unclear on
>   this but not doing this causes an immediate EOF when seeking backwards
>   to the beginning in mpv.
> 
> - only set song duration and packet pts when they are non-negative and
>   in int64 range. NaNs count as out of range. this isn't a fix for any
>   specific issue but might be helpful still, and shouldn't break
>   anything.

can you split this in 3 patches, it sounds like these are 3 distinct changes

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".