From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 93AA04C580 for ; Sun, 3 Aug 2025 23:08:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2A1F268C30D; Mon, 4 Aug 2025 02:08:46 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2374F68B349 for ; Mon, 4 Aug 2025 02:08:40 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5B6A743384 for ; Sun, 3 Aug 2025 23:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754262519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pm1NaPhxXCoHS4jWESmmAYYnbyCj/lLlgFCUkRcIl1I=; b=DNWGef0R8fsEppFrl0xg8kGx/5Hclqx1/8Y2ern2rsYe+0Td5RKgkE3YMzq5FcsiWQr+PI Kj77Gx+i3EdTC6q+ycfL3jqT13BZGsKLrBEdOrUlh9DdsH7otHxMKmG6G1vwpfFqXMyIE6 8fZI0Q+zWgf+MNwieLxexgVcSGfuAfwQeICOklab0ZIas9JLabxYtmNWnY8EzWxiyzg7nv gC1UtAHdwdhAac/nWOKujaBHQEf6HPgX/Kt1AlYYk48oAQI8/RForYn2JxdiO/I27/kDSd jKd5iljoMRsKl/bc5a31eEu9xRYeN2VnalRwgCm0TR9LEN4Yt/0/ZycLBgGO+g== Date: Mon, 4 Aug 2025 01:08:38 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250803230838.GL29660@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduuddtjeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeehkeetkeejleelkefgtdevffehgeekvdejhefftdeghfduiefghfefleejjeetveenucffohhmrghinheptghigidrtghordhukhenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/itut35: always check the provider code and country code together X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3063771075877361494==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3063771075877361494== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uZ0oAAvIxG6JUei1" Content-Disposition: inline --uZ0oAAvIxG6JUei1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Maryla On Wed, Jun 25, 2025 at 05:55:45PM +0200, Maryla Ustarroz-Calonge via ffmpe= g-devel wrote: > Date: Wed, 25 Jun 2025 17:55:45 +0200 > From: Maryla Ustarroz-Calonge > To: ffmpeg-devel@ffmpeg.org > Subject: [PATCH v2] avcodec/itut35: always check the provider code and co= untry code together >=20 > From: Maryla >=20 > ITU-T T.35 provider codes are attributed by national bodies and it's > possible to have collisions across countries. This is why the country code > must always be checked as well. >=20 > Use if statements rather than nested switches which would be unreadable. >=20 > Rename some of the constants to match the corresponding organization. Renaming should be a seperate patch > Add a constant for AOM. > Write all constants with 4 hex digits to make it clear that they are 2-by= te ids. >=20 > The code for V-Nova should be 0x5000 instead of 0x0050 according to the > UK Register of Manufacturer Codes https://www.cix.co.uk/~bpechey/H221/h22= 1code.htm > but I have been unable to find any reference for what code should be used= for > LCEVC, and the author of the original change has not replied to my emails. this should be a seperate patch in general, please split this up a bit to make it easier to review [...] > diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c > index f4cbc927b5..a1158a23c4 100644 > --- a/libavcodec/libdav1d.c > +++ b/libavcodec/libdav1d.c > @@ -386,6 +386,80 @@ static int libdav1d_receive_frame_internal(AVCodecCo= ntext *c, Dav1dPicture *p) > return res; > } > =20 > +static int parse_itut_t35_metadata(Libdav1dContext *dav1d, Dav1dPicture = *p, > + const Dav1dITUTT35 *itut_t35, AVCodec= Context *c, > + AVFrame *frame) { > + GetByteContext gb; > + int provider_code, country_code; > + int res; please split the factorization of code from changes to the code. That way the changes are clearer vissible in the patch thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some people wanted to paint the bikeshed green, some blue and some pink. People argued and fought, when they finally agreed, only rust was left. --uZ0oAAvIxG6JUei1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaI/r6QAKCRBhHseHBAsP q/rJAJ0fBRQoS0TR/t/NbCMJXma/8UtBCgCfY3mEyda623XynZOgmfbqNoZ/rJI= =pi5n -----END PGP SIGNATURE----- --uZ0oAAvIxG6JUei1-- --===============3063771075877361494== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3063771075877361494==--