* [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
@ 2025-07-31 2:13 Cai Fan
2025-07-31 4:01 ` Zhao Zhili
2025-07-31 8:21 ` [FFmpeg-devel] [PATCH v2 " Cai Fan
0 siblings, 2 replies; 4+ messages in thread
From: Cai Fan @ 2025-07-31 2:13 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Cai Fan
Signed-off-by: Cai Fan <caifan0425@163.com>
---
libavformat/img2enc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
index 41638d92b8..a1eb0c688d 100644
--- a/libavformat/img2enc.c
+++ b/libavformat/img2enc.c
@@ -180,7 +180,12 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
}
for (i = 0; i < 4; i++) {
av_dict_copy(&options, img->protocol_opts, 0);
- snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
+ int len = snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
+ if (len < 0 || len >= sizeof(img->tmp[i])) {
+ av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename);
+ ret = AVERROR(EINVAL);
+ goto fail;
+ }
av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
if (s->io_open(s, &pb[i], img->use_rename ? img->tmp[i] : filename, AVIO_FLAG_WRITE, &options) < 0) {
av_log(s, AV_LOG_ERROR, "Could not open file : %s\n", img->use_rename ? img->tmp[i] : filename);
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
2025-07-31 2:13 [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated Cai Fan
@ 2025-07-31 4:01 ` Zhao Zhili
2025-07-31 8:21 ` [FFmpeg-devel] [PATCH v2 " Cai Fan
1 sibling, 0 replies; 4+ messages in thread
From: Zhao Zhili @ 2025-07-31 4:01 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Cai Fan
> On Jul 31, 2025, at 10:13, Cai Fan <caifan0425@163.com> wrote:
>
> Signed-off-by: Cai Fan <caifan0425@163.com>
> ---
> libavformat/img2enc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
> index 41638d92b8..a1eb0c688d 100644
> --- a/libavformat/img2enc.c
> +++ b/libavformat/img2enc.c
> @@ -180,7 +180,12 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
> }
> for (i = 0; i < 4; i++) {
> av_dict_copy(&options, img->protocol_opts, 0);
> - snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> + int len = snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> + if (len < 0 || len >= sizeof(img->tmp[i])) {
> + av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename);
“filename exceeds buffer size %zu\n”.
> + ret = AVERROR(EINVAL);
> + goto fail;
> + }
> av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
> if (s->io_open(s, &pb[i], img->use_rename ? img->tmp[i] : filename, AVIO_FLAG_WRITE, &options) < 0) {
> av_log(s, AV_LOG_ERROR, "Could not open file : %s\n", img->use_rename ? img->tmp[i] : filename);
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [FFmpeg-devel] [PATCH v2 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
2025-07-31 2:13 [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated Cai Fan
2025-07-31 4:01 ` Zhao Zhili
@ 2025-07-31 8:21 ` Cai Fan
2025-08-03 22:57 ` Michael Niedermayer
1 sibling, 1 reply; 4+ messages in thread
From: Cai Fan @ 2025-07-31 8:21 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: caifan0425
Signed-off-by: Cai Fan <caifan0425@163.com>
---
libavformat/img2enc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
index 41638d92b8..9a5718a8da 100644
--- a/libavformat/img2enc.c
+++ b/libavformat/img2enc.c
@@ -180,7 +180,12 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
}
for (i = 0; i < 4; i++) {
av_dict_copy(&options, img->protocol_opts, 0);
- snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
+ int len = snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
+ if (len < 0 || len >= sizeof(img->tmp[i])) {
+ av_log(s, AV_LOG_ERROR, "filename '%s' exceeds buffer size %zu\n", filename, sizeof(img->tmp[i]));
+ ret = AVERROR(EINVAL);
+ goto fail;
+ }
av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
if (s->io_open(s, &pb[i], img->use_rename ? img->tmp[i] : filename, AVIO_FLAG_WRITE, &options) < 0) {
av_log(s, AV_LOG_ERROR, "Could not open file : %s\n", img->use_rename ? img->tmp[i] : filename);
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
2025-07-31 8:21 ` [FFmpeg-devel] [PATCH v2 " Cai Fan
@ 2025-08-03 22:57 ` Michael Niedermayer
0 siblings, 0 replies; 4+ messages in thread
From: Michael Niedermayer @ 2025-08-03 22:57 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1223 bytes --]
On Thu, Jul 31, 2025 at 04:21:35PM +0800, Cai Fan wrote:
> Signed-off-by: Cai Fan <caifan0425@163.com>
> ---
> libavformat/img2enc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
> index 41638d92b8..9a5718a8da 100644
> --- a/libavformat/img2enc.c
> +++ b/libavformat/img2enc.c
> @@ -180,7 +180,12 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
> }
> for (i = 0; i < 4; i++) {
> av_dict_copy(&options, img->protocol_opts, 0);
> - snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> + int len = snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> + if (len < 0 || len >= sizeof(img->tmp[i])) {
> + av_log(s, AV_LOG_ERROR, "filename '%s' exceeds buffer size %zu\n", filename, sizeof(img->tmp[i]));
> + ret = AVERROR(EINVAL);
> + goto fail;
> + }
is there a reason this doesnt use av_asprintf() ?
that is allocate as needed
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No great genius has ever existed without some touch of madness. -- Aristotle
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-03 22:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-31 2:13 [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated Cai Fan
2025-07-31 4:01 ` Zhao Zhili
2025-07-31 8:21 ` [FFmpeg-devel] [PATCH v2 " Cai Fan
2025-08-03 22:57 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git