Re: [FFmpeg-devel] [PATCH v2 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel]  [PATCH v2 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
Date: Mon, 4 Aug 2025 00:57:00 +0200
Message-ID: <20250803225700.GK29660@pb2> (raw)
In-Reply-To: <20250731082135.3114297-1-caifan0425@163.com>

[-- Attachment #1.1: Type: text/plain, Size: 1223 bytes --]

On Thu, Jul 31, 2025 at 04:21:35PM +0800, Cai Fan wrote:
> Signed-off-by: Cai Fan <caifan0425@163.com>
> ---
>  libavformat/img2enc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
> index 41638d92b8..9a5718a8da 100644
> --- a/libavformat/img2enc.c
> +++ b/libavformat/img2enc.c
> @@ -180,7 +180,12 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
>      }
>      for (i = 0; i < 4; i++) {
>          av_dict_copy(&options, img->protocol_opts, 0);
> -        snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> +        int len = snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> +        if (len < 0 || len >= sizeof(img->tmp[i])) {
> +            av_log(s, AV_LOG_ERROR, "filename '%s' exceeds buffer size %zu\n", filename, sizeof(img->tmp[i]));
> +            ret = AVERROR(EINVAL);
> +            goto fail;
> +        }

is there a reason this doesnt use av_asprintf() ?
that is allocate as needed

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".