From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id CBAE74C569 for ; Sun, 3 Aug 2025 22:26:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5FE18687CAC; Mon, 4 Aug 2025 01:26:27 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 43101687CAC for ; Mon, 4 Aug 2025 01:26:20 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5DA6943275; Sun, 3 Aug 2025 22:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754259979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSq7VfxI1yMhDrR7D2AXOSN4QkRXZj+xO1vYRmeNE1A=; b=Q+C0e6GjK4HXjIYB+av0J/iSuLlbCmQpEJsemC04ubftacVwklgxUBa5ry76Z23vz+R8QJ 8r8Nn9oTNRF9jrl75GTSV/Wex8Ldr5THr/lZn7wLaWuuznSQjVe/gC2RTXSfvo1bCyjwYN +C5OnhzelPVbOl7PN1tJO98cvCgD5s5Gk1pt3x98AjAV87nKYowuL1ecHNYQ9tgNMuLy6j ORuK7wN043KKC7NAKANEd9SszN2FWYncJ3vurb+4J3wI90FPdtEQ4tqZAtlBr8wJHsIRoy yILU11zBY7RnyZwxMDX/YvD9MWuMYsoqgWzQV6zuUDAUkQsqK+nqDp0tlt3Yjg== Date: Mon, 4 Aug 2025 00:26:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250803222618.GJ29660@pb2> References: <20250414135931.76495-2-nowrep@gmail.com> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduuddtieehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhephffgvdeifeejveettedvffeltefggfeijedugfetleevteetjeehudeggeeijefhnecuffhomhgrihhnpehfihgvlhgushdrshgvrghrtghhpdhffhhmphgvghdrohhrghenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepfedprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhgpdhrtghpthhtoheptfhuihhjihhnghdrffhonhhgsegrmhgurdgtohhmpdhrtghpthhtohepnhhofihrvghpsehgmhgrihhlrdgtohhm X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix ref_order_hint value for second slot X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Dong, Ruijing" , David Rosca Content-Type: multipart/mixed; boundary="===============6259458100365358719==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6259458100365358719== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EIK86F2uD76mHxuf" Content-Disposition: inline --EIK86F2uD76mHxuf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ruijing, David it seems theres no active maintainer for this To move this patch forward, maybe you know someone who wants to help with maintaince. Or maybe AMD might be interrested in having one of their employees officially maintain AMD related hw accelleration in ffmpeg ? thx On Wed, Jul 30, 2025 at 08:01:36PM +0000, Dong, Ruijing via ffmpeg-devel wr= ote: > [AMD Official Use Only - AMD Internal Distribution Only] >=20 > Without this fix, av1 vaapi encoding on navi3x (vcn4) is broken. >=20 > Thanks, > Ruijing >=20 > -----Original Message----- > From: ffmpeg-devel On Behalf Of David R= osca > Sent: Thursday, July 24, 2025 6:04 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix ref_order_= hint value for second slot >=20 > On Thu, Jun 5, 2025 at 2:17=E2=80=AFPM David Rosca wro= te: > > > > On Mon, Apr 14, 2025 at 4:00=E2=80=AFPM David Rosca = wrote: > > > > > > We always use two slots, even when only one L0 reference is > > > supported by the driver. However we still need to set the correct > > > value for the ref_order_hint of the second slot. > > > > > > Fixes bf9f921ef7 ("avcodec/hw_base_encode: restrict size of > > > next_prev") > > > > Ping >=20 > Ping again, this should go in before 8.0 release to fix the regression. >=20 > Thanks, > David > > > > > --- > > > libavcodec/vaapi_encode_av1.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/libavcodec/vaapi_encode_av1.c > > > b/libavcodec/vaapi_encode_av1.c index 1b350cd936..cf0ff53edc 100644 > > > --- a/libavcodec/vaapi_encode_av1.c > > > +++ b/libavcodec/vaapi_encode_av1.c > > > @@ -476,6 +476,7 @@ static int vaapi_encode_av1_init_picture_params(A= VCodecContext *avctx, > > > AV1RawFrameHeader *fh =3D &fh_obu->obu.frame.head= er; > > > VAEncPictureParameterBufferAV1 *vpic =3D vaapi_pic->codec_pictur= e_params; > > > CodedBitstreamFragment *obu =3D &priv->current_obu; > > > + CodedBitstreamAV1Context *cbctx =3D priv->cbc->priv_data; > > > FFHWBaseEncodePicture *ref; > > > VAAPIEncodeAV1Picture *href; > > > int slot, i; > > > @@ -523,6 +524,8 @@ static int vaapi_encode_av1_init_picture_params(A= VCodecContext *avctx, > > > fh->ref_frame_idx[3] =3D href->slot; > > > fh->ref_order_hint[href->slot] =3D ref->display_order - = href->last_idr_frame; > > > vpic->ref_frame_ctrl_l0.fields.search_idx1 =3D > > > AV1_REF_FRAME_GOLDEN; > > > + } else { > > > + fh->ref_order_hint[!href->slot] =3D > > > + cbctx->ref[!href->slot].order_hint; > > > } > > > break; > > > case FF_HW_PICTURE_TYPE_B: > > > -- > > > 2.49.0 > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >=20 > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.or= g with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >=20 > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle --EIK86F2uD76mHxuf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaI/iBwAKCRBhHseHBAsP qxWRAJ45ykpB6ljRJD0GYBeICyOhv24iVACdEfUpcDNJYQPlsv4vpd75ZoBN528= =+bpr -----END PGP SIGNATURE----- --EIK86F2uD76mHxuf-- --===============6259458100365358719== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6259458100365358719==--