From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A13E04C563 for ; Sun, 3 Aug 2025 21:36:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1C6FA68B5A1; Mon, 4 Aug 2025 00:36:39 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DB20368B5A1 for ; Mon, 4 Aug 2025 00:36:31 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3490142EF2 for ; Sun, 3 Aug 2025 21:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1754256991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JDREsfvBfPPGJGDEcxh+TZC4KDbUFyBwU0GiG6veS9s=; b=A1Xch3eqBdRmIMPPHNr7nZdjGP6ngP0IPqDzgAwC9DPZagu8cz8Xpr1T3MHVpFiEXNihjt 8WaI91Mo7lblvn/BSJry56SP+PJMi4wbHfdNbEktHFbp+6COwtSADX+zq83Ftl8iHgkq67 mAuC9P/Aubzs0VIOWwPrKacBkwxfRO6RZw9VhnD1RXDwJ24ZrtTFcKMCkjIU7NOLkBI1Gd p4sn7/291Lm2LQ0N19diWtLewIonxZvHtGVxfZ1dck8peul1Wmbka3P23zVbJ6ralB8g+R kUwquaPx7rlxKgdMyDWoo0YZZx8+p9rcjHjW/qdOtaLWk5M7GufjGDDPntZrcA== Date: Sun, 3 Aug 2025 23:36:30 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250803213630.GI29660@pb2> References: <20250604165852.75087-1-romain.beauxis@gmail.com> <20250614225713.GP29660@pb2> <20250621215947.GY29660@pb2> <20250728002212.GX29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduuddtheehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeevueefgeefudetuefggfeivdetteekgfdukedtjeeuffevheegleduleffudfgheenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2281316891600910348==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2281316891600910348== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nTnUXeNrjP2XssP4" Content-Disposition: inline --nTnUXeNrjP2XssP4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Mon, Jul 28, 2025 at 04:12:13PM -0500, Romain Beauxis wrote: > Le dim. 27 juil. 2025 =E0 19:22, Michael Niedermayer > a =E9crit : > > > > Hi Romain > > > > On Wed, Jul 23, 2025 at 02:06:07PM -0500, Romain Beauxis wrote: > > > Le sam. 21 juin 2025 =E0 16:59, Michael Niedermayer < > michael@niedermayer.cc> > > > a =E9crit : > > > > > > > > On Sat, Jun 21, 2025 at 10:45:32AM +0200, Romain Beauxis wrote: > > > > > Le dim. 15 juin 2025 =E0 00:57, Michael Niedermayer > > > > > a =E9crit : > > > > > > > > > > > > On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote: > > > > > > > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 > using a > > > flat > > > > > > > memory storage for the extradata. > > > > > > > > > > > > > > PR review comments addressed: > > > > > > > * Use flat memory bytestream > > > > > > > * Re-use existing xiph extradata layout > > > > > > > > > > > > > > --- > > > > > > > > > > > > > libavcodec/vorbisdec.c | 42 ++++++++--- > > > > > > > libavformat/oggparsevorbis.c | 83 > > > +++++++++++++++++++++- > > > > > > > > > > > > patches that change both libraries at the same time are suspect > > > > > > > > > > > > if one depends on changes in the other it needs > > > > > > minor API version bump and seperate patches so extension of > > > > > > API and use of it are properly tracked and testable > > > > > > > > > > If I remember well, according to Andreas Rheinhardt there's no ne= ed > > > > > for an API bump here since the patch is re-using existing extrada= ta > > > > > bitstream structures. > > > > > > > > If there is really no API extension then the micro versions should = be > > > bumped > > > > so a user knows if the specific version he uses has teh fix. > > > > Also it may be usefull in bugreports about ogg to know if its prior= or > > > > after this change > > > > > > Hi Michael, > > > > > > I have created a PR on code.ffmpeg.org here: > > > https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026 > > > > > > > > Would you have a minute to have a look? > > > > I do not have time, ive made a dumb mistake in configuring my inbox > > so iam about a week behind with emails without realizing it. > > thats on top of release, security, and other things > > > > maybe someome else can look into this one > > replying here so noone waits for a review from me >=20 > Thanks for letting me know and sorry about your issues with your email > inbox. >=20 > Do you have any advice on how to look for a reviewer for this path? social media, like twitter also if it has a positive vibe then we can retweet thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato=20 --nTnUXeNrjP2XssP4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaI/WXgAKCRBhHseHBAsP q7j2AJ0XJq29sH23VoTYPjmrCeoW+oANXQCfeKREXSeH5oZys5vZyd08V5fl+IE= =7O4t -----END PGP SIGNATURE----- --nTnUXeNrjP2XssP4-- --===============2281316891600910348== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2281316891600910348==--