From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_packet_free() to avoid memory leak
Date: Sun, 3 Aug 2025 20:09:38 +0000
Message-ID: <20250803200938.931-1-jiashengjiangcool@gmail.com> (raw)
Add av_packet_free() to free avpkt_clone and avpkt in the error paths to avoid potential memory leak.
Fixes: da3c69a5a9 ("Added test for libavcodec/avpacket.c")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
libavcodec/tests/avpacket.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/tests/avpacket.c b/libavcodec/tests/avpacket.c
index 1d4833839a..de76591f17 100644
--- a/libavcodec/tests/avpacket.c
+++ b/libavcodec/tests/avpacket.c
@@ -101,11 +101,14 @@ int main(void)
if(!avpkt_clone) {
av_log(NULL, AV_LOG_ERROR,"av_packet_clone failed to clone AVPacket\n");
+ av_packet_free(&avpkt);
return 1;
}
/*test av_grow_packet*/
if(av_grow_packet(avpkt_clone, 20) < 0){
av_log(NULL, AV_LOG_ERROR, "av_grow_packet failed\n");
+ av_packet_free(&avpkt_clone);
+ av_packet_free(&avpkt);
return 1;
}
if(av_grow_packet(avpkt_clone, INT_MAX) == 0){
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-08-03 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-03 20:09 Jiasheng Jiang [this message]
2025-08-03 23:33 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250803200938.931-1-jiashengjiangcool@gmail.com \
--to=jiashengjiangcool@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git