* [FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_free() to avoid memory leak
@ 2025-08-03 19:14 Jiasheng Jiang
2025-08-03 23:32 ` Michael Niedermayer
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2025-08-03 19:14 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Jiasheng Jiang
Add av_free() to free extra_data if av_packet_add_side_data() fails.
Fixes: da3c69a5a9 ("Added test for libavcodec/avpacket.c")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
libavcodec/tests/avpacket.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/tests/avpacket.c b/libavcodec/tests/avpacket.c
index 1d4833839a..b81b0df1c0 100644
--- a/libavcodec/tests/avpacket.c
+++ b/libavcodec/tests/avpacket.c
@@ -51,6 +51,7 @@ static int setup_side_data_entry(AVPacket* avpkt)
ret = av_packet_add_side_data(avpkt, AV_PKT_DATA_NEW_EXTRADATA,
extra_data, bytes);
if(ret < 0){
+ av_free(extra_data);
fprintf(stderr,
"Error occurred in av_packet_add_side_data: %s\n",
av_err2str(ret));
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_free() to avoid memory leak
2025-08-03 19:14 [FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_free() to avoid memory leak Jiasheng Jiang
@ 2025-08-03 23:32 ` Michael Niedermayer
0 siblings, 0 replies; 2+ messages in thread
From: Michael Niedermayer @ 2025-08-03 23:32 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 578 bytes --]
On Sun, Aug 03, 2025 at 07:14:38PM +0000, Jiasheng Jiang wrote:
> Add av_free() to free extra_data if av_packet_add_side_data() fails.
>
> Fixes: da3c69a5a9 ("Added test for libavcodec/avpacket.c")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
> libavcodec/tests/avpacket.c | 1 +
> 1 file changed, 1 insertion(+)
>
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Elect your leaders based on what they did after the last election, not
based on what they say before an election.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-03 23:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-03 19:14 [FFmpeg-devel] [PATCH] avcodec/tests/avpacket: Add av_free() to avoid memory leak Jiasheng Jiang
2025-08-03 23:32 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git