From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id CCBD54C4DD for ; Sun, 3 Aug 2025 18:36:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EAC8068CB37; Sun, 3 Aug 2025 21:36:34 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7AE3F68AEB1 for ; Sun, 3 Aug 2025 21:36:28 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 573IaRS8018843 for ; Sun, 3 Aug 2025 20:36:28 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id BE6802EFE3; Sun, 3 Aug 2025 20:36:27 +0200 (CEST) From: Nicolas George To: ffmpeg-devel@ffmpeg.org Date: Sun, 3 Aug 2025 20:36:08 +0200 Message-ID: <20250803183624.310641-1-george@nsup.org> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sun, 03 Aug 2025 20:36:28 +0200 (CEST) Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_sched: do not print error code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The error codes are meaningless to users, especially the ones that do not come from standard errno codes. Signed-off-by: Nicolas George --- fftools/ffmpeg_sched.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index 3180367576..ba9708b65b 100644 --- a/fftools/ffmpeg_sched.c +++ b/fftools/ffmpeg_sched.c @@ -2534,7 +2534,7 @@ static void *task_wrapper(void *arg) ret = task->func(task->func_arg); if (ret < 0) av_log(task->func_arg, AV_LOG_ERROR, - "Task finished with error code: %d (%s)\n", ret, av_err2str(ret)); + "Task finished with error: %s\n", av_err2str(ret)); err = task_cleanup(sch, task->node); ret = err_merge(ret, err); @@ -2549,9 +2549,12 @@ static void *task_wrapper(void *arg) pthread_mutex_unlock(&sch->finish_lock); } - av_log(task->func_arg, ret < 0 ? AV_LOG_ERROR : AV_LOG_VERBOSE, - "Terminating thread with return code %d (%s)\n", ret, - ret < 0 ? av_err2str(ret) : "success"); + if (ret < 0) + av_log(task->func_arg, AV_LOG_ERROR, + "Terminating thread with error: %s\n", av_err2str(ret)); + else + av_log(task->func_arg, AV_LOG_VERBOSE, + "Terminating thread with success\n"); return (void*)(intptr_t)ret; } -- 2.47.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".