From: vytskalt via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: vytskalt <VytskaLT@protonmail.com>
Subject: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix memory leak in drm->vulkan mapping
Date: Fri, 01 Aug 2025 11:23:48 +0000
Message-ID: <20250801112341.986117-1-VytskaLT@protonmail.com> (raw)
From: vytskalt <vytskalt@protonmail.com>
If ff_vk_exec_discard_deps is not called after ff_vk_exec_add_dep_frame
we get a reference cycle causing the frames context to never be freed.
Same situation as in 74e27d9e3182d2d256d11bb0d5d45633b054bbcb
Signed-off-by: vytskalt <VytskaLT@protonmail.com>
---
libavutil/hwcontext_vulkan.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
index 6d7df3e619..f0b0dcd0a4 100644
--- a/libavutil/hwcontext_vulkan.c
+++ b/libavutil/hwcontext_vulkan.c
@@ -3426,8 +3426,12 @@ static int vulkan_map_from_drm_frame_sync(AVHWFramesContext *hwfc, AVFrame *dst,
});
err = ff_vk_exec_submit(&p->vkctx, exec);
- if (err < 0)
+ if (err < 0) {
+ ff_vk_exec_discard_deps(&p->vkctx, exec);
return err;
+ }
+
+ ff_vk_exec_wait(&p->vkctx, exec);
} else
#endif
{
--
2.49.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-08-01 11:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801112341.986117-1-VytskaLT@protonmail.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=VytskaLT@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git